Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[x2cpg] Redirect stdout/stderr to tmp files #5027

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

max-leuthaeuser
Copy link
Contributor

@max-leuthaeuser max-leuthaeuser commented Oct 24, 2024

This bypasses tty buffering and read timeouts.
Ubuntu runner time here on GH went from 27min down to 17min.

This bypasses tty buffering.
@max-leuthaeuser max-leuthaeuser changed the title WIP: [x2cpg] Redirect stdout/stderr to tmp files [x2cpg] Redirect stdout/stderr to tmp files Oct 24, 2024
@max-leuthaeuser max-leuthaeuser marked this pull request as ready for review October 24, 2024 11:00
Copy link
Contributor

@mpollmeier mpollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow that's quite an impact in runtime...

@max-leuthaeuser max-leuthaeuser merged commit 3bda95e into master Oct 24, 2024
5 checks passed
@max-leuthaeuser max-leuthaeuser deleted the max/externalCommandToFile branch October 24, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants