Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include node id in json (for StoredNode) #4979

Merged
merged 1 commit into from
Sep 30, 2024
Merged

include node id in json (for StoredNode) #4979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions semanticcpg/src/main/scala/io/shiftleft/semanticcpg/language/Steps.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,19 @@ class Steps[A](val traversal: Iterator[A]) extends AnyVal {
object Steps {
private lazy val nodeSerializer = new CustomSerializer[AbstractNode](implicit format =>
(
{ case _ => ??? },
{ case _ => ??? }, // deserializer not required for now
{ case node: AbstractNode =>
val elementMap = (0 until node.productArity).map { i =>
val elementMap = Map.newBuilder[String, Any]
(0 until node.productArity).foreach { i =>
val label = node.productElementName(i)
val element = node.productElement(i)
label -> element
}.toMap + ("_label" -> node.label)
Extraction.decompose(elementMap)
elementMap.addOne(label -> element)
}
elementMap.addOne("_label" -> node.label)
if (node.isInstanceOf[StoredNode]) {
elementMap.addOne("_id" -> node.asInstanceOf[StoredNode].id())
}
Extraction.decompose(elementMap.result())
}
)
)
Expand Down
3 changes: 3 additions & 0 deletions semanticcpg/src/test/scala/io/shiftleft/semanticcpg/language/StepsTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ class StepsTest extends AnyWordSpec with Matchers {
val parsed = parse(json).children.head // exactly one result for the above query
(parsed \ "_label") shouldBe JString("METHOD")
(parsed \ "name") shouldBe JString("foo")

// id should be defined, but we don't care what number it is
(parsed \ "_id") shouldBe a[JInt]
}

"operating on NewNode" in {
Expand Down
Loading