[dataflowengineoss] Turn Semantics into a node-directed trait
#4920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierpinho
requested review from
mpollmeier,
maltek,
DavidBakerEffendi and
max-leuthaeuser
mpollmeier
reviewed
Sep 16, 2024
There was a problem hiding this comment.
Sounds like a good idea from my POV, but since I'm not super familiar with Semantics I'll pass the torch to someone else, maybe @DavidBakerEffendi for approval..?
DavidBakerEffendi
approved these changes
Sep 16, 2024
|
FYI I've experimented with representing parameters undergoing fine-grained operations such as field accesses and calls within a method, and that used a similar approach as above, but was pretty difficult (not undoable though). This already makes the semantic DSL more readable though. |
|
@xavierpinho do you have permissions to merge? |
I have, thanks for asking :) Was just giving it some time in case someone wanted to chime in any other feedback first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently,
Semanticsare exclusively based on method fullNames and, while that is perfectly reasonable for statically typed languages such as Java, they are not so great for dynamic ones.The proposal here is to turn
Semanticsinto a common trait equipped with aforMethod :: Method -> Option[FlowSemantic]operation, that can take into account more information (since it's given the node itself) other than just its fullName. In doing so, I also renamed the currentSemanticsclass toFullNameSemantics, to make it clear what the latter operates on.In particular, this would allow users of Joern as-a-library to provide their own custom
Semanticsinstance, that can inform the dataflowengine on a node-by-node basis.If this proposal is welcomed, I also intend to refactor
SemanticTestCpgand friends to allow customSemanticobjects, instead ofFullNameSemanticsexclusively. Moreover, I'd also like to introduce aNoCrossTaintsemantics -- essentially a liftedPassThroughMapping. This patch is already too large as is, so I refrained from doing so at this point.