Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Emit TypeRef instead of MethodRef for Lambdas #4753

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

DavidBakerEffendi
Copy link
Collaborator

Due to Ruby method references being called via a .call() method, the type ref that should be emitted, is one that contains the .call method, but is not necessarily the same type as the one bound to the actual lambda. This makes that change, however, data-flow no longer works in the open-source data-flow tracker as this is not supported.

@DavidBakerEffendi DavidBakerEffendi added the ruby Relates to rubysrc2cpg label Jul 10, 2024
@DavidBakerEffendi DavidBakerEffendi requested a review from ml86 July 10, 2024 09:14
@DavidBakerEffendi DavidBakerEffendi self-assigned this Jul 10, 2024
@DavidBakerEffendi DavidBakerEffendi merged commit 18b6d88 into master Jul 10, 2024
5 checks passed
@DavidBakerEffendi DavidBakerEffendi deleted the dave/ruby/method-to-type-ref branch July 10, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Relates to rubysrc2cpg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants