This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
Support other casings for view-controller
#76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The decision to use dash-casing for the `view-controller` property matches the multi-word precedent set by the [Turbo iOS examples][]. However, the [Turbo Android examples][] uses snake_casing. It's unlikely that an Android app and an iOS app will share exact copies of a path configuration file's structure and data. However, it's possible that they'd share a similar server-side backend to generate those files, or a shared naming convention across those files. The `view-controller` appears to be the only multi-word key expected and supported out-of-the-box, with the expectation that other keys can be used to inform bespoke features in app-specific contexts. This commit expands that support to match other naming conventions, mainly snake_case and camelCase. [Turbo iOS examples]: https://github.com/hotwired/turbo-ios/blob/c9d060fcdec136c3808cd0764e956d375012c6fb/Docs/PathConfiguration.md#path-configuration [Turbo Android examples]: https://github.com/hotwired/turbo-android/blob/bf945e18aed3d5749c9efc6e228d98bc012878af/docs/PATH-CONFIGURATION.md#path-configuration
seanpdoyle
commented
Dec 6, 2023
| if let viewController = properties["view-controller"] as? String { | ||
| return viewController | ||
| } | ||
| let viewControllers = ["view-controller", "view_controller", "viewController"].map { properties[$0] }.filter { $0 as? String } |
There was a problem hiding this comment.
I am an amateur Swift developer reaching for Ruby-isms. If there's a more idiomatic way to do this, I'd love to learn it!
joemasilotti
reviewed
Dec 6, 2023
|
Hey Sean, after discussing with the other maintainers we've decided to consolidate case. Everything, across both platforms, will use snake case moving forward. This better matches Rails routes and requires the least amount of change across iOS and Android. You can check out the turbo-navigator branch if you'd like to see how everything is handled and take it for a spin. I'm hoping to merge that in pretty soon! Thanks for the PR, it kicked off a good discussion. And I think we are in a much better spot because of it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decision to use dash-casing for the
view-controllerproperty matches the multi-word precedent set by the Turbo iOS examples. However, the Turbo Android examples uses snake_casing.It's unlikely that an Android app and an iOS app will share exact copies of a path configuration file's structure and data. However, it's possible that they'd share a similar server-side backend to generate those files, or a shared naming convention across those files.
The
view-controllerappears to be the only multi-word key expected and supported out-of-the-box, with the expectation that other keys can be used to inform bespoke features in app-specific contexts.This commit expands that support to match other naming conventions, mainly snake_case and camelCase.