zlib: fix use after null when calling .close

An internal zlib error may cause _handle to be set to null. Close now will check if there is a _handle prior to calling .close on it. PR-URL: nodejs#5982 Fixes: nodejs#6034 Reviewed-By: Brian White <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
joelostrowski · Apr 25, 2016 · 8dbd5c5 · 8dbd5c5
1 parent 0324c24
commit 8dbd5c5
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/zlib.js b/lib/zlib.js
@@ -474,7 +474,10 @@ function _close(engine, callback) {
 
   engine._closed = true;
 
-  engine._handle.close();
+  // Caller may invoke .close after a zlib error (which will null _handle).
+  if (engine._handle) {
+    engine._handle.close();
+  }
 }
 
 function emitCloseNT(self) {