-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to set prefixes/suffixes for generated classes #258
Conversation
Thanks for contributing this. We need some integration tests to make sure this feature works (and is not broken in a future version). If you check out the tests here: it should be easy to work out how they are written. There are helper functions to invoke the plugin and compile the result. Could you add a PrefixSuffixIT there? Cheers |
Sure, I'll add PrefixSuffixIT |
Done. |
Thanks Eimar, it looks like the tests aren't currently passing. Could you take a look? https://travis-ci.org/joelittlejohn/jsonschema2pojo/jobs/38265276 |
The tests have been updated and they are now passing. |
Sorry for the delay. Looking at the code there is just one case I that I think may not work, do your changes in ObjectRule support classes in the default package? (no Also, would you mind squashing all commits into one before I merge this? Many thanks. |
sure, i'll put them in one commit. why that? I'll check the case you mention tomorrow and you'll see the commit popping up. I think this pull request can be closed, right? |
How do you pass the default package? like this: ?
|
Hi Eimar.
This is simply to keep a clean history. There's a little discussion of this here: http://www.booleanknot.com/blog/2013/09/07/pull-requests.html
Using this test helper you could use an empty string as the package name: generateAndCompile("/schema/properties/primitiveProperties.json", "", config("classNamePrefix","Abstract")); |
No description provided.