Add support for android library plugin

[yomik]

0.4.8 added support for Android gradle plugin (com.android.application).

However, it lacks support for Android libraries (com.android.library). It would be nice to have support for these as well.

[joelittlejohn]

Could you elaborate a bit on what you can and can't do with the current android support? I don't fully understand why this plugin needs to explicitly support these libraries. Can you not simply add this dependency yourself? Or do you need this plugin to recognise com.android.library as something that should be treated as an android plugin?

Hopefully @ben-manes and @samskiter could offer an opinion on this too :)

[samskiter]

@joelittlejohn this is probably the same basic issue as #266

@yomik i guess you are receiving an error about the java plugin being incompatible with the android plugin.

I imagine that this should be an easy fix for someone who knows more about the system.

Looks as though it would just require an addition here:

https://github.com/joelittlejohn/jsonschema2pojo/blob/master/jsonschema2pojo-gradle-plugin/src/main/groovy/org/jsonschema2pojo/gradle/GenerateJsonSchemaTask.groovy#L44

[joelittlejohn]

Is this something that every Gradle plugin has to go through? Something
doesn't feel right about this but I don't know enough Gradle projects to
understand this :)
On 11 Mar 2015 16:38, "Sam Duke" [email protected] wrote:

@joelittlejohn https://github.com/joelittlejohn this is probably the
same basic issue as #266
#266

@yomik https://github.com/yomik i guess you are receiving an error
about the java plugin being incompatible with the android plugin.

I imagine that this should be an easy fix for someone who knows more about
the system.

Looks as though it would just require an addition here:

https://github.com/joelittlejohn/jsonschema2pojo/blob/master/jsonschema2pojo-gradle-plugin/src/main/groovy/org/jsonschema2pojo/gradle/GenerateJsonSchemaTask.groovy#L44

—
Reply to this email directly or view it on GitHub
#305 (comment)
.

[samskiter]

im probably less familiar. are there any other ways to integrate other than as a plugin?

[ben-manes]

I didn't realize that the Android stack has two plugins (library and application). As Sam said, its probably as simple as adding an OR condition to inspect for that plugin as well. I'd like to have a sample project like last time to verify with.

Most Gradle plugins don't have this complexity with Android as they don't need to integrate into a compilation workflow. This is one of the few cases where Maven's phase model is easier than a task graph, because the code generation would always occur prior to the compiler plugin's execution. In Gradle, we need to setup the dependencies which due to Android's non-standard workflow adds complexity. We could of course make our users configure the DAG themselves, but that would annoy them and spam you with a lot of basic setup questions.

If @yomik provided a sample project, perhaps by extending @samskiter's, this should be an easy task.

[joelittlejohn]

Fantastic, thanks for the detailed explanation Ben.
On 11 Mar 2015 19:46, "Ben Manes" [email protected] wrote:

I didn't realize that the Android stack has two plugins (library and
application). As Sam said, its probably as simple as adding an OR condition
to inspect for that plugin as well. I'd like to have a sample project like
last time to verify with.

Most Gradle plugins don't have this complexity with Android as they don't
need to integrate into a compilation workflow. This is one of the few cases
where Maven's phase model is easier than a task graph, because the code
generation would always occur prior to the compiler plugin's execution. In
Gradle, we need to setup the dependencies which due to Android's
non-standard workflow adds complexity. We could of course make our users
configure the DAG themselves, but that would annoy them and spam you with a
lot of basic setup questions.

If @yomik https://github.com/yomik provided a sample project, perhaps
by extending @samskiter https://github.com/samskiter's, this should be
an easy task.

—
Reply to this email directly or view it on GitHub
#305 (comment)
.

[yomik]

Sorry, I should have given more details.

@ben-manes I checked the official Android documentation (https://developer.android.com/tools/building/plugin-for-gradle.html) and apparently the library part is omitted. It is referenced in the (outdated) documentation : http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Library-projects but has the deprecated naming "android-library", which changed to "com.android.library" (this has been announced in the changelog of the Android gradle plugin at some time but I couldn't find it).

@samskiter I'm getting the error "generateJsonSchema: Java or Android plugin required", thrown exactly where the link you gave points at.

I believe the fix consists in adding "com.android.library" to the condition, with the same call to configureAndroid().

I will try to provide a sample project later.

I realize that this is very confusing for a non-Android developer :/

[ben-manes]

@yomik Take a look at the sample that Sam provided us for the android-application plugin support. You could either extend it or adapt a new example based on it, if that helps.

[ben-manes]

@yomik Just checked up on this issue and I see that you have a branch with a sample and the fix. If it works, can you send a pull request? The changes lgtm except that I'd ask to keep it to 100c by indenting the second clause in the if statement.

[ben-manes]

Oh, just found #311. Closing