Skip to content

Commit

Permalink
[8.x] Cannot skip tests named "values" (elastic#115096) (elastic#115111)
Browse files Browse the repository at this point in the history
* Cannot skip tests named "values" (elastic#115096)

When trying to use a gradle `skipTest` rule on tests named "values", we get a class-caste exception in Jackson.

This PR needs to rename this function for all versions of Elasticsearch that the `yamlRestCompatTestTransform` task will run on, so that later PRs that add skipTests will be able to pass. Since this test was added in 8.14, we must backport all the way back to there.

```
class com.fasterxml.jackson.databind.node.IntNode cannot be cast to class com.fasterxml.jackson.databind.node.ArrayNode (com.fasterxml.jackson.databind.node.IntNode and com.fasterxml.jackson.databind.node.ArrayNode are in unnamed module of loader org.gradle.internal.classloader.VisitableURLClassLoader$InstrumentingVisitableURLClassLoader @50337c96)
```

* Mutes from main that are needed on 8.x
  • Loading branch information
craigtaverner authored Oct 18, 2024
1 parent 9e7d3a7 commit 6124836
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
12 changes: 12 additions & 0 deletions muted-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,18 @@ tests:
- class: org.elasticsearch.compute.aggregation.blockhash.BlockHashRandomizedTests
method: test {forcePackedHash=false groups=1 maxValuesPerPosition=1 dups=2 allowedTypes=[Ordinals[dictionarySize=10]]}
issue: https://github.com/elastic/elasticsearch/issues/115105
- class: org.elasticsearch.index.mapper.TextFieldMapperTests
method: testBlockLoaderFromRowStrideReaderWithSyntheticSource
issue: https://github.com/elastic/elasticsearch/issues/115066
- class: org.elasticsearch.index.mapper.TextFieldMapperTests
method: testBlockLoaderFromColumnReaderWithSyntheticSource
issue: https://github.com/elastic/elasticsearch/issues/115073
- class: org.elasticsearch.index.mapper.annotatedtext.AnnotatedTextFieldMapperTests
method: testBlockLoaderFromColumnReaderWithSyntheticSource
issue: https://github.com/elastic/elasticsearch/issues/115074
- class: org.elasticsearch.index.mapper.annotatedtext.AnnotatedTextFieldMapperTests
method: testBlockLoaderFromRowStrideReaderWithSyntheticSource
issue: https://github.com/elastic/elasticsearch/issues/115076

# Examples:
#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ setup:
- match: { values.1.0: "Payroll Specialist" }

---
values:
"values function":
- requires:
cluster_features: esql.agg_values
reason: "values is available in 8.14+"
Expand Down

0 comments on commit 6124836

Please sign in to comment.