This repository has been archived by the owner on Jan 24, 2020. It is now read-only.
remove unused getAll with arity 2 from RCT_EXPORT_METHOD #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have forked the repo here: https://github.com/safaiyeh/react-native-cookie-store |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. Currently if I try to call
CookieManager.getAll()it will throw exception complaining the arity difference between native and js code.I am not too familiar with object-c and react bridge code but I belive the function I remove from this PR is not needed anymore and it solve the exception when calling
getAll.Please let me know if there is any problem so I can further imrpove it.