WIP: Working on HTTP2 client #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -601,7 +601,7 @@ handle_info({inet_async, _ListSock, Ref, {ok, CliSocket}}, | |||
| ssl -> | |||
| {ok, AcceptSocket} = ssl:ssl_accept(CliSocket, SSLOptions), | |||
| %% TODO: Erlang 18 uses ALPN | |||
| {ok, _Upgrayedd} = ssl:negotiated_next_protocol(AcceptSocket), | |||
There was a problem hiding this comment.
IIRC this needs to be a switch based on erlang version 17/18
There was a problem hiding this comment.
You are right. What is a sane way of doing that? Macro party?
|
Hey, take a look at what I've done in http2_client on master. |
|
a bunch of client dev has happened since this was opened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ongoing PR to work on the HTTP2 client that comes with Chatterbox.
My goals are to:
For now I'm not looking to: