Switch javascript:void(0) to preventDefault

Stack Exchange says this is a better solution.
jobsaustralia · Sep 22, 2017 · d4d6d66 · d4d6d66
1 parent 455799b
commit d4d6d66
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 14 deletions.
diff --git a/public/js/custom.js b/public/js/custom.js
@@ -1,5 +1,7 @@
 /* Generic function to toggle the display of an element. */
 function toggleDisplay(){
+    event.preventDefault();
+
     var element = document.getElementById(event.target.id + "-content");
 
     if(element.style.display == "none"){
@@ -25,7 +27,7 @@ function randomiseTeam(){
     /* https://stackoverflow.com/a/6274381 */
     function shuffle(a){
         var j, x, i;
-        for (i = a.length; i; i--) {
+        for(i = a.length; i; i--){
             j = Math.floor(Math.random() * i);
             x = a[i - 1];
             a[i - 1] = a[j];
@@ -61,20 +63,11 @@ function randomiseTeam(){
 
 /* Function to automatically populate relevant fields when student checkbox is checked on registration page. */
 function studentFill(){
-    if(document.getElementById("student").checked){
+    if(this.checked){
         document.getElementById("title").value = "Student";
-        document.getElementById("title").readOnly = true;
         document.getElementById("sector").value = "None";
-        document.getElementById("sector").readOnly = true;
         document.getElementById("experience").value = 0;
     }
-    else{
-        document.getElementById("title").value = null;
-        document.getElementById("title").readOnly = false;
-        document.getElementById("sector").value = null;
-        document.getElementById("sector").readOnly = false;
-        document.getElementById("experience").value = null;
-    }
 }
 
 /* Function to submit POST data to server with form in the background. */
@@ -85,6 +78,8 @@ function submitForm(){
 
 /* Function to autofill skills from GitHub. */
 function autoFill(){
+    event.preventDefault();
+
     document.getElementById("github-error-generic").style.display = "none";
     document.getElementById("github-error-username").style.display = "none";
 

diff --git a/resources/views/auth/register.blade.php b/resources/views/auth/register.blade.php
@@ -168,7 +168,7 @@
 
                         <div class="form-group">
                             <p align ="center">
-                                <a href="javascript:void(0)" id="autofill-btn" class="btn btn-primary">
+                                <a id="autofill-btn" class="btn btn-primary">
                                     Autofill skills from GitHub
                                 </a>
                             </p>

diff --git a/resources/views/edit.blade.php b/resources/views/edit.blade.php
@@ -154,7 +154,7 @@
 
                         <div class="form-group">
                             <p align ="center">
-                                <a href="javascript:void(0)" id="autofill-btn" class="btn btn-primary">
+                                <a id="autofill-btn" class="btn btn-primary">
                                     Autofill skills from GitHub
                                 </a>
                             </p>

diff --git a/resources/views/profile.blade.php b/resources/views/profile.blade.php
@@ -42,7 +42,7 @@
 
                     <div id="confirm-delete-content" style="display: none;">
                         <p>
-                            Confirm deletion: <a id="really-confirm-delete" class="text-danger" href="javascript:void(0)">I really want to delete my account.</a>
+                            Confirm deletion: <a id="really-confirm-delete" class="text-danger" href="#">I really want to delete my account.</a>
                         </p>
 
                         <div id="really-confirm-delete-content" style="display: none;">