-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Python3-only reusable thread executor #214
base: master
Are you sure you want to change the base?
[WIP] Python3-only reusable thread executor #214
Conversation
Umm, so a bunch of features and bugfixes were added to the |
After an IRL talk with @tomMoral, I'm going to not backport all features/bugfixes made to the |
Supersedes #189.
This is a Python3-only implementation of a reusable
ThreadPoolExecutor
. Making this Python3-only limits the maintainability burden ofloky
by not making us backportthreading
utilities forPython2
.In particular, this PR implements a new
_ReusableThreadPoolExecutor
class. The appropriate tests from theloky
as well as theconcurrent.futures.ThreadPoolExecutor
test suite are ran against it.As a result, most of the changes in this code are test-suite additions-refactoring:
[Theme]ProcessExecutorTest
classesconcurrent.futures
There is still a bunch of style/renaming to do, but the major part of the work is done.