Skip to content

Commit

Permalink
Revert to old yauzl version
Browse files Browse the repository at this point in the history
Revert "Take yauzl update but keep devDeps, temporarily"

This reverts commit 9dddf4f.

Revert "Handle error from github.downloadAsset"

This reverts commit b8fd6a9.

Revert "Update to fix with latest yauzl, and fix roblourens#3"

This reverts commit 8176795.
  • Loading branch information
joaomoreno committed Jul 18, 2017
1 parent 9dddf4f commit 64a2f05
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
5 changes: 0 additions & 5 deletions dist/download.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ function download(opts, assetName, downloadDest) {
const assetDownloadPath = path.join(downloadDest, assetName);

github.downloadAsset(asset, (error, istream) => {
if (error) {
return reject(error);
}

console.log(`Downloading to ${assetDownloadPath}`);
if (process.stdout.isTTY && !opts.quiet) {
const bar = new ProgressBar('↓ ' + asset.name + ' [:bar] :percent', {
Expand Down Expand Up @@ -68,7 +64,6 @@ function unzip(zipPath, destinationDir) {
yauzl.open(zipPath, { lazyEntries: true }, (err, zipFile) => {
if (err) return reject(err);

zipFile.readEntry();
zipFile.on('entry', entry => {
zipFile.openReadStream(entry, (err, readStream) => {
if (err) return reject(err);
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vscode-ripgrep",
"version": "0.0.15",
"version": "0.0.12",
"description": "Downloads the ripgrep binary shipped in VS Code",
"main": "dist/index.js",
"repository": {
Expand All @@ -16,6 +16,6 @@
"github-releases": "^0.3.2",
"mkdirp": "^0.5.1",
"progress": "^1.1.8",
"yauzl": "^2.8.0"
"yauzl": "2.3.1"
}
}

0 comments on commit 64a2f05

Please sign in to comment.