Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/table activepage prop #61

Closed

Conversation

vlrmprjct
Copy link

Request type

I need the ability to change the table page programmaticly.
For example reading URL params or using interactive elements everywhere in an application to change the active table page.
Now it is also possible to write an independent <Pagination /> component without using the build-in one, so you have full control about the markup.

Change description

There is a new prop called activePage, the default value is 1.
Also I changed the example a bit.

Check lists

  • Tests passed
  • Coding style respected

@joaocarmo joaocarmo assigned joaocarmo and vlrmprjct and unassigned joaocarmo Nov 20, 2021
@joaocarmo joaocarmo self-requested a review November 20, 2021 21:46
@joaocarmo joaocarmo added the feature A new feature to be added label Nov 20, 2021
@joaocarmo
Copy link
Owner

joaocarmo commented Nov 20, 2021

Thank you so much for your contribution, @vlrmprjct!

Though I can see the need for something like #60, I'm not sure this particular solution fits the philosophy of the smart data table with batteries included.

I added a working example in this comment.

@vlrmprjct
Copy link
Author

I withdraw this PR.
There is no need for this solution.
See #60 (comment)

@vlrmprjct vlrmprjct closed this Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination and activePage prop
2 participants