Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package supports ESM import declarations #131

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

ibrittanyhill
Copy link
Contributor

@ibrittanyhill ibrittanyhill commented Jan 17, 2024

Request type

  • Feature
  • Fix
  • Refactor
  • Tests
  • Documentation

Summary

This allows projects using ESM import declarations to import PostalAddress as usual if they choose to upgrade to the latest version.

Change description

After v0.4.3 this ability was removed. Without this, this error is returned on our end:

Compiled with problems:

Module not found: Error: Package path . is not exported from package
/../node_modules/i18n-postal-address (see exports field in /../node_modules/i18n-postal-address/package.json

We'd like to be able to use the latest version of this package when it becomes available and without this line in the package.json file I'm unable to see the new countries added to address-formats.ts

Check lists

  • Tests passed
  • Coding style respected

@ibrittanyhill
Copy link
Contributor Author

ibrittanyhill commented Jan 17, 2024

Whoops, wonder if this is similar to #49? Sorry if I should've opened an issue first

@joaocarmo joaocarmo added the bug Something isn't working label Jan 18, 2024
Copy link
Owner

@joaocarmo joaocarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joaocarmo joaocarmo merged commit d45b7ab into joaocarmo:main Jan 20, 2024
3 of 4 checks passed
@ibrittanyhill ibrittanyhill deleted the bh/package-import branch January 22, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants