Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added cocktail amount adjustment in detail modal #519

Merged

Conversation

jo-gross
Copy link
Owner

Closing issues:

Before you mark this PR as ready, please check the following points

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I´e created all necessary migrations?
  • The format is correct (pnpm format:check, if invalid pnpm format:fix)
  • No build errors (pnpm build)
  • I´ve tested the implemented function by my own
  • Ensure the pr title fits the conventional commit standard

Describe your work, what changed

Its now possible to adjust the amount of the cocktail in percentage, changing the ingreident amounts. When changing the default amount, the "add to list with note" gets prefilled with the new amounts as comment.

Affected sites (please check during review):

  • Detail dialog of a cocktail

@jo-gross jo-gross self-assigned this Jan 20, 2025
@jo-gross jo-gross linked an issue Jan 20, 2025 that may be closed by this pull request
1 task
@jo-gross jo-gross enabled auto-merge (squash) January 20, 2025 12:53
Signed-off-by: Johannes Groß <[email protected]>
@jo-gross jo-gross disabled auto-merge January 28, 2025 20:28
@jo-gross jo-gross merged commit bc04259 into main Jan 28, 2025
5 checks passed
@jo-gross jo-gross deleted the 515-feat-add-cocktail-amount-adjustment-to-detail-modal branch January 28, 2025 20:28
jg-semantic-release-bot bot pushed a commit that referenced this pull request Jan 28, 2025
# [1.11.0](v1.10.0...v1.11.0) (2025-01-28)

### Bug Fixes

* Added cocktail name to add rating modal ([ace4dd9](ace4dd9))
* Fixed number localization and cocktail queue mobile layout ([#510](#510)) ([4e4adcb](4e4adcb))
* Made long notes, history, and description fields collapsible ([#503](#503)) ([87ded4e](87ded4e))
* Made page titles consistent ([d32b735](d32b735))
* Moved user settings to separate page ([#532](#532)) ([dc252b0](dc252b0))
* Named all entities in the delete confirmation dialog ([#516](#516)) ([a5d146e](a5d146e))
* Rating in the search modal has now the correct value ([3cd8824](3cd8824))

### Features

* Added 'group by day' option in statistics ([#527](#527)) ([d2c5440](d2c5440))
* Added cocktail amount adjustment in detail modal ([#519](#519)) ([bc04259](bc04259))
* Added cocktail´s tag suggestion based on the ingredient tags ([#512](#512)) ([4a5b9ff](4a5b9ff))
* Improved workspace join process ([#522](#522)) ([834af42](834af42))
@jg-semantic-release-bot
Copy link

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add cocktail amount adjustment to detail modal
1 participant