Merge pull request #583 from jmortlock/fix-nested-params

Correctly handle nested params
jnunemaker · Mar 20, 2018 · db8df8c · db8df8c
2 parents 1a52a13 + c51cb3e
commit db8df8c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/httparty/hash_conversions.rb b/lib/httparty/hash_conversions.rb
@@ -26,7 +26,7 @@ def self.to_params(hash)
     def self.normalize_param(key, value)
       normalized_keys = normalize_keys(key, value)
 
-      normalized_keys.inject('') do |string, (k, v)|
+      normalized_keys.flatten.each_slice(2).inject('') do |string, (k, v)|
         string + "#{k}=#{ERB::Util.url_encode(v.to_s)}&"
       end
     end

diff --git a/spec/httparty/hash_conversions_spec.rb b/spec/httparty/hash_conversions_spec.rb
@@ -11,6 +11,13 @@
       }
       expect(HTTParty::HashConversions.to_params(hash)).to eq("name=bob&address[street]=111%20ruby%20ave.&address[city]=ruby%20central&address[phones][]=111-111-1111&address[phones][]=222-222-2222")
     end
+
+    context "nested params" do
+      it 'creates a params string from a hash' do
+        hash = { marketing_event: { marketed_resources: [ {type:"product", id: 57474842640 } ] } }
+        expect(HTTParty::HashConversions.to_params(hash)).to eq("marketing_event[marketed_resources][][type]=product&marketing_event[marketed_resources][][id]=57474842640")
+      end
+    end
   end
 
   describe ".normalize_param" do