Fix issue where AsciiStringRef.set() and UTF8StringRef.set() would throw an IllegalArgumentException.

[charleskorn]

Fixes #159.

I've added a basic test case for the scenario that fails without this fix and passes with the fix.

I'm not sure if my changes are correct though:

• should UTFStringRef.set() also update this.length to the length of the new string value?
• should we be allocating additional space for the null terminator character in the call to getRuntime().getMemoryManager().allocateDirect()?

[headius]

• should UTFStringRef.set() also update this.length to the length of the new string value?
• should we be allocating additional space for the null terminator character in the call to getRuntime().getMemoryManager().allocateDirect()?

These are good questions but perhaps they are not related to this fix? In other words, I think both of these would have been issues before, so we don't need to address them as part of your fix... maybe?

The fix seems right. We should investigate the above issues and try to get answers there, but I think we can merge this without addressing them right now.

What do you think?

[charleskorn]

Up to you, you know this stuff much better than I do @headius :)

Are you able to pick up the investigation of those two items? I don't know enough about the expected / desired behaviour to investigate them properly.

[headius]

I will try to investigate the two issues soon and get a new release out... might take a bit to circle back to this though.

[charleskorn]

Any chance this could be merged and released @headius?

[headius]

Yeah, I've been under the weather and finally getting back to work. Could you open additional issues for those open questions you have? I will merge this now.

[charleskorn]

No worries at all, I've opened an issue for them: #285