Expose fan via Homekit #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jnimmo thoughts on merging this? Since we don't have numbered releases it's a bit hard to communicate the breaking change to people using it. Might be worth it though? |
..and add more debugging to climate setup
|
I've added versioned releases, which means we can release this properly with release notes! :yay: |
|
Thanks @jbergler looks good! And nice work on setting up the release workflow. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Homekit expects fan settings as
auto,low,medium,highInternally the intesis box has this as
AUTO,1,2,3This change translates these, with the side effect that the fan settings in home assistant will change, breaking automations, etc.
Fixes #27
Also included: a compatibility fix which may address #29