core: Fix -Wrange-loop-analysis

jngrad · Oct 28, 2020 · 926fce0 · 926fce0
1 parent 7af98c5
commit 926fce0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -387,6 +387,7 @@ target_compile_options(
             $<$<BOOL:${WARNINGS_ARE_ERRORS}>:-Werror>
             # add extra warnings
             $<$<CXX_COMPILER_ID:Clang>:-Wextern-initializer>
+            $<$<CXX_COMPILER_ID:Clang>:-Wrange-loop-analysis>
             # disable warnings from -Wextra
             -Wno-sign-compare
             -Wno-unused-function

diff --git a/src/core/cluster_analysis/ClusterStructure.cpp b/src/core/cluster_analysis/ClusterStructure.cpp
@@ -54,7 +54,7 @@ void ClusterStructure::run_for_all_pairs() {
 void ClusterStructure::run_for_bonded_particles() {
   clear();
   for (const auto &p : partCfg()) {
-    for (auto const &bond : p.bonds()) {
+    for (auto const bond : p.bonds()) {
       if (bond.partner_ids().size() == 1) {
         add_pair(p, get_particle_data(bond.partner_ids()[0]));
       }

diff --git a/src/core/particle_data.cpp b/src/core/particle_data.cpp
@@ -964,7 +964,7 @@ void auto_exclusions(int distance) {
   /* determine initial connectivity */
   for (auto const &part1 : partCfg()) {
     auto const p1 = part1.p.identity;
-    for (auto const &bond : part1.bonds()) {
+    for (auto const bond : part1.bonds()) {
       if ((bond.partner_ids().size() == 1) and (bond.partner_ids()[0] != p1)) {
         auto const p2 = bond.partner_ids()[0];
         add_partner(partners[p1], p1, p2, 1);