Prevent arbitrary EL expression evaluation #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pwntester thanks! 😄 🚀 |
|
@jmrozanec did you intend to merge both our PRs in relation to the RCE? This one makes the validator kind of useless, as you don't get any feedback anymore on what's wrong with the cron expression. |
|
@jmrozanec I agree that @NielsDoucet PR is a better fix for the issue and should be merged instead of this one |
|
@pwntester @NielsDoucet I apologize for the lack of responsiveness - I had some busy days :) I will fix the code towards the @NielsDoucet solution, release a new cron-utils version, and issue the security advisory. Will ping you back in the following days. I appreciate your time and effort on this - thanks! 😄 🚀 |
jmrozanec
added a commit
that referenced
this pull request
Nov 14, 2021
|
@pwntester @NielsDoucet version 9.1.7 was released with this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.