Added support for passing options to watchify (watchifyOptions). #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to how browserifyOptions are passed to browserify, this PR allows options in watchifyOptions to be passed to watchify.
|
Looks good to me, this even allow users to customize the delay for watchify (not documented though) |
tleunen
pushed a commit
that referenced
this pull request
Feb 27, 2015
Added support for passing options to watchify (watchifyOptions).
|
Isn't this dependent on browserify/watchify#126 getting merged in? |
|
For this specific usecase, yes, but even without that, you know have the possibility to customize the |
|
@amchang in the meantime you can also use this fork: https://github.com/sagansystems/watchify/tree/chokidar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how browserifyOptions are passed to browserify, this PR allows options in watchifyOptions to be passed to watchify.
Very useful in Docker containers, so we can pass chokidar.usePolling=true to watchify: browserify/watchify#126.