Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for potentially unsafe external link #402

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Fix for potentially unsafe external link #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion admin/static/js/query.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,10 @@ function confirmDeleteSavedQueries(_names, _url) {
}

function queryResultLink(link, query, url) {
var external_link = '<a href="' + link + '" _target="_blank"><i class="fas fa-external-link-alt"></i></a>';
var external_link =
'<a href="' +
link +
'" _target="_blank" rel="noopener noreferrer"><i class="fas fa-external-link-alt"></i></a>';
return '<span class="query-link"><a href="' + url + '">' + query + '</a> - ' + external_link + '</span> ';
}

Expand Down
2 changes: 1 addition & 1 deletion admin/templates/queries-logs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
{{ else }}
<i class="fas fa-hourglass-half"></i> [ <b>ACTIVE</b> ] - Results for {{ .Name }}
{{ end }}
- <a href="{{ queryResultLink .Name $template.EnvUUID }}" target="_blank"><i class="fas fa-external-link-alt"></i></a>
- <a href="{{ queryResultLink .Name $template.EnvUUID }}" target="_blank" rel="noopener noreferrer"><i class="fas fa-external-link-alt"></i></a>
<div class="card-header-actions">
<button class="btn btn-sm btn-outline-primary" data-tooltip="true"
data-placement="bottom" title="Refresh table" onclick="refreshTableNow('tableQueryLogs');">
Expand Down
2 changes: 1 addition & 1 deletion admin/templates/queries-run.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<div class="card mt-2">
<div class="card-header">
<i class="fas fa-table"></i>
<a href="https://osquery.io/schema/{{ $.TablesVersion }}" target="_blank">
<a href="https://osquery.io/schema/{{ $.TablesVersion }}" target="_blank" rel="noopener noreferrer">
osquery {{ $.TablesVersion }}:
</a>
<div class="card-header-actions">
Expand Down
Loading