Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix invalid logging method for api, default to none #34

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

friedbutter
Copy link
Contributor

@friedbutter friedbutter commented Jan 30, 2020

There is an error in the generated api.json.

"db" is not a valid option in validLogging in api/main.go:102

var validLogging = map[string]bool{
	settings.LoggingNone: true,
}

This was the error I got:

~/g/osctrl ❯❯❯ docker logs -f 0593dd8239167c3cc113779241b4cfc59896b9dbb1e19a0d603ffdf5ce926459
Postgres is up - Starting osctrl-api
main.go:109: Loading config/api.json
main.go:153: Error loading config/api.json - Invalid logging method: 'db'
Postgres is up - Starting osctrl-api
main.go:109: Loading config/api.json
main.go:153: Error loading config/api.json - Invalid logging method: 'db'

Nit: adding method in error strings to help with debugging.

@javuto javuto added the 🐛 bug Something isn't working label Jan 31, 2020
@javuto javuto added this to the v0.2.0 milestone Jan 31, 2020
@javuto
Copy link
Collaborator

javuto commented Feb 10, 2020

Nice catch, thanks for the PR! 🙌

@javuto javuto merged commit 27909a6 into jmpsec:master Feb 10, 2020
@javuto javuto mentioned this pull request Feb 25, 2020
@javuto javuto added 🚧 bugfix Fix for an existing bug and removed 🐛 bug Something isn't working labels Dec 15, 2020
CptOfEvilMinions added a commit that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 bugfix Fix for an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants