Implement TabSheet lazy tabs 3029 #3094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebfox
requested changes
Apr 4, 2024
jmix-flowui/flowui/src/main/java/io/jmix/flowui/component/tabsheet/JmixTabSheet.java
Outdated
Show resolved
Hide resolved
jmix-flowui/flowui/src/main/java/io/jmix/flowui/component/tabsheet/JmixTabSheet.java
Outdated
Show resolved
Hide resolved
jmix-flowui/flowui/src/main/java/io/jmix/flowui/xml/layout/loader/container/TabSheetLoader.java
Outdated
Show resolved
Hide resolved
jmix-flowui/flowui/src/main/java/io/jmix/flowui/xml/layout/loader/container/TabSheetLoader.java
Outdated
Show resolved
Hide resolved
glebfox
requested changes
Apr 5, 2024
jmix-flowui/flowui/src/main/java/io/jmix/flowui/component/tabsheet/JmixTabSheetUtils.java
Outdated
Show resolved
Hide resolved
jmix-flowui/flowui/src/main/java/io/jmix/flowui/xml/layout/loader/container/TabSheetLoader.java
Outdated
Show resolved
Hide resolved
glebfox
requested changes
Apr 10, 2024
jmix-flowui/flowui/src/main/java/io/jmix/flowui/facet/impl/SettingsFacetHelper.java
Outdated
Show resolved
Hide resolved
jmix-flowui/flowui/src/main/java/io/jmix/flowui/xml/layout/loader/container/TabSheetLoader.java
Outdated
Show resolved
Hide resolved
| @@ -124,6 +164,23 @@ public Component getContent() { | |||
| } | |||
| } | |||
|
|
|||
| public static class LazyTabLoader extends TabLoader { | |||
There was a problem hiding this comment.
We don't need it if we don't create it
| ComponentLoader<?> componentLoader = loader.getLoader(subElement, TabLoader.class); | ||
| componentLoader.initComponent(); | ||
| boolean shouldBeLazy = loadBoolean(subElement, "lazy").orElse(false) && !firstTab; | ||
| ComponentLoader<?> componentLoader = loader.getLoader(subElement, |
There was a problem hiding this comment.
Here we already know if a tab is lazy, so we can skip creating Loader and putting it in pendingLoadComponents. If a tab is lazy, it'd be more efficient to store an element rather than a loader instance. A loader can be created in the selectedTabChangeHandler on demand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3029