Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom functions not visible/available in let expressions #29

Closed
mikaelforslund opened this issue Aug 27, 2024 · 1 comment · Fixed by #32
Closed

Custom functions not visible/available in let expressions #29

mikaelforslund opened this issue Aug 27, 2024 · 1 comment · Fixed by #32

Comments

@mikaelforslund
Copy link

mikaelforslund commented Aug 27, 2024 •
edited
Loading

Looks like custom functions kept in the functionTable are lost when a new scope is created in TreeInterpreter.ts.

I can create a PR for a fix if nobody is working on that at the moment?
@springcomp
Copy link
Contributor

Hi @mikaelforslund thanks for your feedback.
If you have a test that exhibits this issue then a PR would be greatly appreciated.

springcomp added a commit that referenced this issue Oct 25, 2024
@springcomp
Let expressions learned to use custom registered functions (#29)
18373f3
@springcomp springcomp mentioned this issue Oct 25, 2024
Merged
springcomp added a commit that referenced this issue Oct 25, 2024
@springcomp
Let expressions learns to use custom registered functions (#32)
a29e14d 
* fixed vulnerabilities

* clarified intent for usage of a type

* removed compiler warning

* Let expressions learned to use custom registered functions (#29)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Let expressions learns to use custom registered functions jmespath-community/typescript-jmespath
2 participants
@mikaelforslund @springcomp