Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make options public to allow custom interpreter usage #102

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

fjogeleit
Copy link
Contributor

To allow the creation and usage of a custom Interpreter it is necessary that the Options struct is public to fulfill the interface and make the usage of the Option interface possible.

Copy link
Collaborator

@eddycharly eddycharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fjogeleit !

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (e430401) to head (c36366c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   88.51%   90.77%   +2.26%     
==========================================
  Files          15       15              
  Lines        2594     2212     -382     
==========================================
- Hits         2296     2008     -288     
+ Misses        204      112      -92     
+ Partials       94       92       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddycharly eddycharly merged commit df67b13 into jmespath-community:main Sep 11, 2024
10 checks passed
@fjogeleit fjogeleit deleted the public-options branch September 11, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants