-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate rhs after string slices #76
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 88.68% 88.70% +0.02%
==========================================
Files 16 16
Lines 2643 2648 +5
==========================================
+ Hits 2344 2349 +5
Misses 207 207
Partials 92 92 ☔ View full report in Codecov by Sentry. |
@eddycharly can you please help me fix the linting errors ? |
@springcomp In depguard v1, enabling depguard without config do nothing. Disabling depguard in .golangci.yml or adding the following settings to .golangci.yml may fix the lint errors. linters-settings:
depguard:
rules:
main:
files:
- $all
- "!$test"
allow:
- $gostd
- github.com/jmespath-community/go-jmespath |
@eddycharly can I kindly request your help in having this PR moving forward ? Linter is now running OK but it seems to fail in codecov, possibly from using an expired token. |
42fcb4e
to
bc8f23a
Compare
Signed-off-by: Springcomp <[email protected]>
Signed-off-by: Springcomp <[email protected]>
Signed-off-by: Springcomp <[email protected]>
bc8f23a
to
5f24797
Compare
Signed-off-by: Springcomp <[email protected]>
732a213
to
36a3417
Compare
Signed-off-by: Springcomp <[email protected]>
36a3417
to
8dda10a
Compare
Fixes #69.