Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate rhs after string slices #76

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Evaluate rhs after string slices #76

merged 5 commits into from
Jan 14, 2025

Conversation

springcomp
Copy link
Contributor

Fixes #69.

@springcomp springcomp requested a review from eddycharly June 21, 2023 20:04
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (a74fd8e) to head (8dda10a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   88.68%   88.70%   +0.02%     
==========================================
  Files          16       16              
  Lines        2643     2648       +5     
==========================================
+ Hits         2344     2349       +5     
  Misses        207      207              
  Partials       92       92              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@springcomp
Copy link
Contributor Author

@eddycharly can you please help me fix the linting errors ?
Is there anything I do wrong?

@kit494way
Copy link

@springcomp
Since depguard v2, default behavior is changed.
OpenPeeDeeP/depguard#55

In depguard v1, enabling depguard without config do nothing.
OpenPeeDeeP/depguard#55 (comment)

Disabling depguard in .golangci.yml or adding the following settings to .golangci.yml may fix the lint errors.

linters-settings:
  depguard:
    rules:
      main:
        files:
          - $all
          - "!$test"
        allow:
          - $gostd
          - github.com/jmespath-community/go-jmespath

@springcomp
Copy link
Contributor Author

springcomp commented Oct 27, 2024

@eddycharly can I kindly request your help in having this PR moving forward ?

Linter is now running OK but it seems to fail in codecov, possibly from using an expired token.

@springcomp springcomp force-pushed the slices-rhs branch 2 times, most recently from 42fcb4e to bc8f23a Compare October 27, 2024 11:30
Signed-off-by: Springcomp <[email protected]>
@springcomp springcomp merged commit a8b468f into main Jan 14, 2025
21 checks passed
@springcomp springcomp deleted the slices-rhs branch January 14, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projected string slices are shortcut
2 participants