Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Parser]: NATS #19

Closed
jmcdo29 opened this issue Mar 28, 2020 · 0 comments · Fixed by #47
Closed

[Parser]: NATS #19

jmcdo29 opened this issue Mar 28, 2020 · 0 comments · Fixed by #47
Labels
enhancement 🐺 A new feature to be implemented good first issue 👍 Good for newcomers help wanted 🆘 Extra attention is needed nats A problem with the NATS parser
Milestone
@ogma/namespace

Comments

@jmcdo29
Copy link
Owner

jmcdo29 commented Mar 28, 2020

Now that the core functionality has been re-written, it would be great to actually include NATS in the request logging.

Looking for: package under the name @ogma/platform-nats that exports a class NatsInterceptorParser that extends AbstractInterceptorService from the @ogma/nestjs-module package.

The output of this is still to be determined. Some values may need to be hard-coded
@jmcdo29 jmcdo29 added help wanted 🆘 Extra attention is needed good first issue 👍 Good for newcomers enhancement 🐺 A new feature to be implemented nats A problem with the NATS parser labels Mar 28, 2020
@jmcdo29 jmcdo29 added this to the @ogma/namespace milestone Mar 28, 2020
jmcdo29 added a commit that referenced this issue May 17, 2020
@jmcdo29
feat(nats): implements NatsParser and test cases
5308a66 
Similarly to the MqttParser, to get the IP address out of the NATS request, it has to be sent over
with the payload. Otherwise, even more straightforward parser than the Mqtt one as Nats has a
function to get the subject, because it accetps wildcards.

fix #19
@jmcdo29 jmcdo29 mentioned this issue May 17, 2020
Merged
jmcdo29 added a commit that referenced this issue May 17, 2020
@jmcdo29
feat(nats): implements NatsParser and test cases (#47)
b9136f8 
Similarly to the MqttParser, to get the IP address out of the NATS request, it has to be sent over
with the payload. Otherwise, even more straightforward parser than the Mqtt one as Nats has a
function to get the subject, because it accetps wildcards.

fix #19
jmcdo29 added a commit that referenced this issue Jun 20, 2021
@jmcdo29
feat(nats): implements NatsParser and test cases (#47)
c8b01d6 
Similarly to the MqttParser, to get the IP address out of the NATS request, it has to be sent over
with the payload. Otherwise, even more straightforward parser than the Mqtt one as Nats has a
function to get the subject, because it accetps wildcards.

fix #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🐺 A new feature to be implemented good first issue 👍 Good for newcomers help wanted 🆘 Extra attention is needed nats A problem with the NATS parser
Projects
None yet
Milestone
@ogma/namespace
Development

Successfully merging a pull request may close this issue.

feat(nats): implements NatsParser and test cases jmcdo29/ogma
1 participant
@jmcdo29