Skip to content
This repository has been archived by the owner on Apr 17, 2021. It is now read-only.

[WIP] Support bootstrap 4 #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Support bootstrap 4 #50

wants to merge 2 commits into from

Conversation

kvdveer
Copy link
Collaborator

@kvdveer kvdveer commented Feb 17, 2016

Bootstrap 4 does not provide any new features for the pager or the paginator. Hoewever, its structure has changed a bit.

We can get away with just using a different template for bootstrap 4. This way we can also easily bring back bootstrap 2 support.

@kvdveer kvdveer self-assigned this Feb 17, 2016
@jarekwg
Copy link

jarekwg commented Sep 22, 2016

+1

Any chance we could get this merged in? It's still easily rebasable against master (tried on my local fork). And seems to be working in our bs4 environment.

@robbiet480
Copy link

robbiet480 commented Aug 12, 2017

Bootstrap 4 beta is out! I just updated this PR to use the (hopefully final) formatting. It's available here. Please note BS4 has removed the pager component. I don't use it so I didn't do anything about it...

@jhotujec
Copy link

Any progress with this? :)

@josvleeuwen
Copy link

josvleeuwen commented Feb 15, 2018

I'm getting the following error:

TemplateDoesNotExist at ...
bootstrap_pagination/pagination.html

@josvleeuwen josvleeuwen mentioned this pull request Feb 15, 2018
@jmcclell
Copy link
Owner

@kvdveer Is this still something you're working on? I've added basic support for Bootstrap 4 for the next release by simply adding the two additional required classes to the pagination tag. The pager tag is the tough one, alas. It doesn't seem to be supported at all in Bootstrap 4. I am wondering if we should just remove it. I looked at what you were doing here and wasn't sure if you were trying to make Pager still work?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants