Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing block faces with modded blocks #178

Closed
PixusPanic opened this issue Nov 28, 2021 · 6 comments
Closed

Missing block faces with modded blocks #178

PixusPanic opened this issue Nov 28, 2021 · 6 comments
Labels

Comments

@PixusPanic
Copy link

Hey; I've been toying around with the latest update to jMc2Obj and I will say that I'm very surprised and impressed that modded block support has been added. It's something I've always wanted to see, and here we are.

I wanted to give out a quick bug report or suggestion, namely that the modded blocks (in this case, MrCrayfish's Furniture Mod and XK's Deco) I've been using always seem to cull the faces below and besides them, regardless if they're not a full block or not. From a programming point of view, I think I get what is happening because the program isn't able to read the block models, so it doesn't know they're not full blocks, but I could be wrong. A way for the program to automate culling for this would be appreciated.
Render

@mmdanggg2
Copy link
Collaborator

Currently it defaults to blocks being solid so any unknown blocks will occlude neighbouring blocks. Take a look at the blocks.conf file, at the moment you need to add the modded blocks in there to override the block properties. The console log should tell you which block ids couldn't be found in the conf file. I might end up switching it so the default is to not occlude, I think more blocks are like that in base minecraft anyway.

@PixusPanic
Copy link
Author

Thanks for your detailed response! I did take a look in there and I wasn't aware the console says which blocks couldn't be found in it, but that'll prove to be useful.
Do you have a guide for adding in new blocks to it?

@mmdanggg2
Copy link
Collaborator

There isn't a guide but it's pretty simple, just copy an existing entry and add it to the end with the new blocks id.
eg.

	<block id="crayfish:table" name="Table">
		<occlusion>none</occlusion>
	</block>

Just change the id to the new blocks' id. The name doesn't really matter, it's only used in the block selection menu.

@PixusPanic
Copy link
Author

Sorry for my late response, but thanks!
Just a suggestion, although the ability to support additional config files (like for example, one configuration file contains vanilla assets, another has just modded assets from a single mod) would be appreciated.

@mmdanggg2
Copy link
Collaborator

That's a good idea, that could be great for making and sharing mod block configs.

mmdanggg2 added a commit that referenced this issue Dec 19, 2021
For easier creation and sharing of mod block configs #178
@mmdanggg2
Copy link
Collaborator

It will now look for any files matching blocks-*.conf in the conf folder and add those definitions.
As a super simple example, here is one for the couple of blocks in my doge mod:
blocks-doge.conf

<?xml version="1.0"?>
<blocks>
	<block id="doge:mining_rig" name="Mining Rig"></block>
	<block id="doge:doge_block" name="Doge Block"></block>
</blocks>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants