Skip to content

Commit

Permalink
[8.x] [Spaces] spaces selector page background (elastic#199981) (elas…
Browse files Browse the repository at this point in the history
…tic#200933)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Spaces] spaces selector page background
(elastic#199981)](elastic#199981)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Elena
Shostak","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T14:23:45Z","message":"[Spaces]
spaces selector page background (elastic#199981)\n\nRemoved `panelled` property
that was covering the background image.\r\nFrom
[EUI\r\ndocs](https://eui.elastic.co/#/templates/page-template/examples#simple-page-with-header-and-sections)\r\n`panelled`
- adds a white background and shadow to define the
area.\r\n\r\n__Closes:
https://github.com/elastic/kibana/issues/194193__\r\n\r\n## Release
Note\r\nRemoved `panelled` property that was covering the background
image for\r\nSpaces Selector
page.","sha":"d435b8a892b79a88de26c74b69b57b617acff12a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Security","Feature:Security/Spaces","v9.0.0","backport:prev-minor"],"title":"[Spaces]
spaces selector page
background","number":199981,"url":"https://github.com/elastic/kibana/pull/199981","mergeCommit":{"message":"[Spaces]
spaces selector page background (elastic#199981)\n\nRemoved `panelled` property
that was covering the background image.\r\nFrom
[EUI\r\ndocs](https://eui.elastic.co/#/templates/page-template/examples#simple-page-with-header-and-sections)\r\n`panelled`
- adds a white background and shadow to define the
area.\r\n\r\n__Closes:
https://github.com/elastic/kibana/issues/194193__\r\n\r\n## Release
Note\r\nRemoved `panelled` property that was covering the background
image for\r\nSpaces Selector
page.","sha":"d435b8a892b79a88de26c74b69b57b617acff12a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199981","number":199981,"mergeCommit":{"message":"[Spaces]
spaces selector page background (elastic#199981)\n\nRemoved `panelled` property
that was covering the background image.\r\nFrom
[EUI\r\ndocs](https://eui.elastic.co/#/templates/page-template/examples#simple-page-with-header-and-sections)\r\n`panelled`
- adds a white background and shadow to define the
area.\r\n\r\n__Closes:
https://github.com/elastic/kibana/issues/194193__\r\n\r\n## Release
Note\r\nRemoved `panelled` property that was covering the background
image for\r\nSpaces Selector
page.","sha":"d435b8a892b79a88de26c74b69b57b617acff12a"}}]}] BACKPORT-->

Co-authored-by: Elena Shostak <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
  • Loading branch information
3 people authored Nov 21, 2024
1 parent 4e2dec9 commit fbb83f3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,7 @@ export class SpaceSelector extends Component<Props, State> {
}

return (
<KibanaPageTemplate
className="spcSpaceSelector"
data-test-subj="kibanaSpaceSelector"
panelled
>
<KibanaPageTemplate className="spcSpaceSelector" data-test-subj="kibanaSpaceSelector">
{/* Portal the fixed background graphic so it doesn't affect page positioning or overlap on top of global banners */}
<EuiPortal>
<div
Expand Down

0 comments on commit fbb83f3

Please sign in to comment.