Skip to content

Commit

Permalink
[Lens] don't use eui variables for zindex (elastic#96117)
Browse files Browse the repository at this point in the history
Co-authored-by: Kibana Machine <[email protected]>
  • Loading branch information
mbondyra and kibanamachine authored Apr 6, 2021
1 parent 251bd9a commit 3a4c62d
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 9 deletions.
5 changes: 5 additions & 0 deletions x-pack/plugins/lens/public/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,8 @@ $lnsPanelMinWidth: $euiSize * 18;
$lnsSuggestionHeight: 100px;
$lnsSuggestionWidth: 150px;
$lnsLayerPanelDimensionMargin: 8px;

$lnsZLevel0: 0;
$lnsZLevel1: 1;
$lnsZLevel2: 2;
$lnsZLevel3: 3;
16 changes: 8 additions & 8 deletions x-pack/plugins/lens/public/drag_drop/drag_drop.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
user-select: none;
transition: $euiAnimSpeedFast ease-in-out;
transition-property: background-color, border-color, opacity;
z-index: $euiZLevel1;
z-index: $lnsZLevel1;
}

.lnsDragDrop_ghost {
Expand All @@ -18,7 +18,7 @@
left: 0;
opacity: .9;
transform: translate(-12px, 8px);
z-index: $euiZLevel3;
z-index: $lnsZLevel3;
pointer-events: none;
box-shadow: 0 0 0 $euiFocusRingSize $euiFocusRingColor;
}
Expand Down Expand Up @@ -58,7 +58,7 @@

// Drop area while hovering with item
.lnsDragDrop-isActiveDropTarget {
z-index: $euiZLevel3;
z-index: $lnsZLevel3;
@include lnsDroppableActiveHover;
}

Expand Down Expand Up @@ -90,7 +90,7 @@
height: 100%;

&.lnsDragDrop__container-active {
z-index: $euiZLevel3;
z-index: $lnsZLevel3;
}
}

Expand All @@ -111,15 +111,15 @@
}

.lnsDragDrop-isActiveDropTarget {
z-index: $euiZLevel3;
z-index: $lnsZLevel3;
}
}

.lnsDragDrop-translatableDrag {
transform: translateY(0);
transition: transform $euiAnimSpeedFast ease-in-out;
position: relative;
z-index: $euiZLevel1;
z-index: $lnsZLevel1;
}

.lnsDragDrop__keyboardHandler {
Expand Down Expand Up @@ -151,7 +151,7 @@
opacity: 0;
visibility: hidden;
position: absolute;
z-index: $euiZLevel2;
z-index: $lnsZLevel2;
right: calc(100% + #{$euiSizeS});
top: 0;
transition: opacity $euiAnimSpeedFast ease-in-out;
Expand All @@ -168,7 +168,7 @@
width: 30%;
top: 0;
left: -$euiSize;
z-index: $euiZLevel0;
z-index: $lnsZLevel0;
}

.lnsDragDrop__extraDropWrapper {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
// This also means needing to add same amount of margin to page content and suggestion items
padding: $euiSize $euiSize 0;
position: relative;
z-index: $euiZLevel1;
z-index: $lnsZLevel1;
&:first-child {
padding-left: $euiSize;
}
Expand Down

0 comments on commit 3a4c62d

Please sign in to comment.