fix: saveAll fails when input list is empty

jloisel · Jan 28, 2016 · 80757fd · 80757fd
1 parent dcb09ef
commit 80757fd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/...h/src/main/java/com/jeromeloisel/db/repository/elasticsearch/ElasticSearchRepository.java b/...h/src/main/java/com/jeromeloisel/db/repository/elasticsearch/ElasticSearchRepository.java
@@ -98,6 +98,10 @@ public T save(final T entity) {
 
   @Override
   public List<T> saveAll(final List<T> entities) {
+    if(entities.isEmpty()) {
+      return entities;
+    }
+
     final BulkRequestBuilder bulk = client
         .prepareBulk()
         .setRefresh(true);

diff --git a/...src/test/java/com/jeromeloisel/db/repository/elasticsearch/RepositoryIntegrationTest.java b/...src/test/java/com/jeromeloisel/db/repository/elasticsearch/RepositoryIntegrationTest.java
@@ -120,6 +120,12 @@ public void shouldSaveAll() {
     assertEquals(1, saved.size());
     repository.delete(saved.get(0));
   }
+
+  @Test
+  public void shouldNotSaveAll() {
+    final List<Person> saved = repository.saveAll(ImmutableList.of());
+    assertEquals(0, saved.size());
+  }
 
   @Test
   public void shouldFindByFirstname() {