-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional HidePreviousComments option which defaults to false #25
Comments
The option |
PyGitHub revision 34d097ce doesn't have API to hide comment in IssueComment. |
GitHub REST API v3 doesn't have an option to hide or minimize comment. Alternative solution is to update comment and collapse the comment content as follows: Outdated AWS CodeBuild CI ReportAWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository Docs: |
The GraphQL API provides minimizeComment option under Mutations. Refs: isaacs/github#1480 I think this project should be good with @jlhood WDYT? |
Instead of updating previous comments while still posting new comments, it's cleaner to just keep updating the same comment without posting new comments. With comment edit history easily accessible on Github, that balances clean threads with arbitrarily large numbers of previous reports |
Is your feature request related to a problem? Please describe.
github-codebuild-logs posts multiple comments based on how many times CodeBuild was run for the PR, which depends on how many times additional pushes were done to PR branch after the PR was posted. Example aws/aws-sdk-js-v3#824
Describe the solution you'd like
Add optional
HidePreviousComments
option which is false by default. When true, it will hide previously posted PR comments as Outdated before posting a new one.Describe alternatives you've considered
DeletePreviousComments
option, but it deletes the comments instead of hiding themThe text was updated successfully, but these errors were encountered: