feat: add event stream serde dependencies #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AllanZhengYP
force-pushed
the
event-stream-utils-dev-1
branch
from
3daeabe to
d264d87
Compare
Codecov Report
@@ Coverage Diff @@
## smithy-codegen #824 +/- ##
=================================================
- Coverage 92.12% 91.9% -0.22%
=================================================
Files 145 150 +5
Lines 2908 3027 +119
Branches 513 529 +16
=================================================
+ Hits 2679 2782 +103
- Misses 229 245 +16
Continue to review full report at Codecov.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AllanZhengYP
force-pushed
the
event-stream-utils-dev-1
branch
from
d264d87 to
71e0ab1
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AllanZhengYP
force-pushed
the
event-stream-utils-dev-1
branch
from
71e0ab1 to
4ef3b40
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AllanZhengYP
force-pushed
the
event-stream-utils-dev-1
branch
from
4ef3b40 to
3441e19
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
srchase
approved these changes
Feb 14, 2020
| * to event stream binary chunks; Use a pull stream | ||
| * here to support low connection speed. | ||
| * | ||
| * This doesn't work actually on browser currently |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
AllanZhengYP
force-pushed
the
event-stream-utils-dev-1
branch
from
3441e19 to
a2b931d
Compare
This comment has been minimized.
This comment has been minimized.
AllanZhengYP
force-pushed
the
event-stream-utils-dev-1
branch
2 times, most recently
from
2e82629 to
fc25e69
Compare
This comment has been minimized.
This comment has been minimized.
feat: revive event stream dependencies feat: allow event signer provider in the config feat: rename util-eventstream-node to eventstream-serde-node feat: separate eventstream serde from util package feat: exprimental event stream signing dependencies feat: add eventstream-serde-browser chore: add doc for not supporting eventstream request on browser chore: add ignore files to eventstream dependencies chore: remove middleware-eventstream-signing from PR chore: remove eventstream-signer-node from PR chore(eventstream-serde-node): add unit tests feat: throw error/exception event and terminate event stream chore: fix docs fix: add eventstream-serde-config-resolver
srchase
approved these changes
Feb 14, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AllanZhengYP
added a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Feb 17, 2020
* feat: add event stream serde dependencies([aws#824](aws#824)) * support eventstream traits([smithy-typescript#110](smithy-lang/smithy-typescript#110))
AllanZhengYP
added a commit
that referenced
this pull request
Feb 17, 2020
* feat: add event stream serde dependencies([#824](#824)) * support eventstream traits([smithy-typescript#110](smithy-lang/smithy-typescript#110))
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change add 3 packages that used to serialize/deserialize the event stream:
@aws-sdk/eventstream-serde-browser: provide anEventStreamMarshallerclass that hasserializeanddeserializemethods.serialize()serializes input into event stream formatted binary stream; Whereasdeserialize()converts output from response ReadableStream to structured output. The implementation is adopted from v2 eventstream@aws-sdk/eventstream-serde-node: Same function to@aws-sdk/eventstream-serde-browserby compatible with NodeJs stream API.@aws-sdk/eventstream-serde-config-resolver: Provide a client config resolver function that resolve client config toEventStreamMarshalleron different runtimes accordingly. This config will apply to client only ifeventstreamtrait is found in model.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.