forked from nix-rust/nix
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This adds the unlinkat function, which is part of POSIX: http://pubs.opengroup.org/onlinepubs/9699919799/functions/unlinkat.html and widely implmented on Unix-family platforms.
- Loading branch information
Showing
4 changed files
with
73 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
890de05
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunfishcode
Two questions here about patch submissions:
In order to update the original patch, I did an amend locally but was forced to you -f when pushing to git hub due to complaints about my tip being behind. Is using -f the correct technique? I am not accustom to needing to use -f when amending remote patches in other git projects plus the original patch appears to now be gone. Is this the github way to update a remote patch intended for a pull request?
In the changelog above, how do I know the pull ID if the pull request hasn't been created yet? Is it intended that I will update this patch again after the pull request?
890de05
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlb6740 I think github always requires -f when pushing an amended commit to a remote repo that already has the unammended commit, because it's effectively replacing the old unamended commit with the new amended one. In any case, it's fine to amend commits and do push -f on your own branches when preparing for a pull request.
For 2, you can submit the original PR using "#TBD" or so, and then amend the patch and push -f once the PR is created.