Fixed broken isreal

Must be a change in Julia since this was last tested?

Add tests and change incorrect & to &&

Fix isinteger and UpToPhase

fixes #6
fixes #7

src/base_applications.jl

@@ -120,7 +120,11 @@ isinteger(x::AbstractFloat, approx_test::AbstractApprox=Equal()) = isapprox(appr
 
 # complex.jl
 isinteger(z::Complex, approx_test::AbstractApprox=Equal()) =
-    isreal(z, approx_test) & isinteger(real(z), approx_test)
+    isreal(z, approx_test) && isinteger(real(z), approx_test)
+
+# TODO: Need to think about difference between real(z) and abs(z) regarding tolerance in all
+# methods for complex numbers (not just isingeger)
+isinteger(z::Complex, approx_test::UpToPhase) = isinteger(abs(z), approx_test)
 
 isinteger(x::Rational, approx_test::AbstractApprox) = isinteger(float(x), approx_test)
 

test/runtests.jl

@@ -29,15 +29,25 @@ import LinearAlgebra
     @test ! iszero(m, Equal()) # exact
 end
 
-@testset "isreal, isinteger" begin
+@testset "isreal" begin
     @test isreal(1)
     @test isreal(1.0)
     @test isreal(1.0, Approx())
     @test ! isreal(1.0 + 1e-10im)
-    @test ! isreal(1.0 + 1e-10im, Approx())
+    @test ! isreal(1.0 + 1e-7im, Approx())
     @test isreal(1.0 + 1e-10im, Approx(atol=1e-9))
+end
+
+@testset "isinteger" begin
     @test isinteger(1)
     @test isinteger(1, Approx())
+    @test isinteger(1 + 1e-8, Approx())
+    @test ! isinteger(1 + 1e-5, Approx())
+    @test isinteger(1000 + 1e-5, Approx())
+    @test isinteger(1 + im * 1e-8, Approx())
+    @test ! isinteger(1 + im * 1e-5, Approx())
+    @test isinteger(exp(im*2), UpToPhase())
+    @test ! isinteger(1.1 * exp(im*2), UpToPhase())
 end
 
 @testset "isdiag" begin