fix error handling if .chartsnap.yaml is invalid

jlandowner · Dec 20, 2023 · e19578e · e19578e
1 parent 9285f4c
commit e19578e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/main.go b/main.go
@@ -224,7 +224,11 @@ func run(cmd *cobra.Command, args []string) error {
 				if f.Name() == o.ConfigFile {
 					cfg, err = charts.LoadSnapshotConfig(path.Join(o.ValuesFile, f.Name()))
 					if err != nil {
-						// err
+						if o.FailFast {
+							return fmt.Errorf("failed to load snapshot config: %w", err)
+						} else {
+							log.Error("warning: failed to load snapshot config", "path", path.Join(o.ValuesFile, f.Name()), "err", err)
+						}
 					}
 					continue
 				}

diff --git a/pkg/charts/testspec.go b/pkg/charts/testspec.go
@@ -14,7 +14,11 @@ func LoadSnapshotConfig(file string) (SnapshotConfig, error) {
 	cfg := SnapshotConfig{}
 	f, err := os.Open(file)
 	if err != nil {
-		return cfg, nil
+		if os.IsNotExist(err) {
+			return cfg, nil // ignore not found
+		} else {
+			return cfg, fmt.Errorf("failed to open config file '%s': %w", file, err)
+		}
 	}
 	defer f.Close()