-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Active crown fire development #5
Active crown fire development #5
Conversation
Sam,
Just going through the steps in case this helps. Not sure where things went
awry, but we can fix it on Monday.
After you fetch my “passive crown fire branch” to your local repo, create a
new branch called “active crown fire”
From your local branch for “active crown fire” use git push to send it to
your repo.
Depending on where things went off, you can also merge this work into a new
branch on your repo. And then push it to your remote
Git push sLevis-repo active-crown-fire
Then create the pull request from your remote “slevis repo”
You can always delete that pr and create a new one from your repo. Then I
can pull “active crown fire” from your repo since you are doing the
development.
Will check in with you on Monday.
On Fri, Sep 6, 2019 at 7:17 PM Samuel Levis ***@***.***> wrote:
@rgknox <https://github.com/rgknox> somehow I opened this PR in @jkshuman
<https://github.com/jkshuman>'s path of PRs. I don't know how...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5?email_source=notifications&email_token=AFIUHBRSPHOQTMROVZLHFMTQIL6I5A5CNFSM4IUOHMVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6EMW2Y#issuecomment-529058667>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFIUHBVGA2XUI5NQAW3P5WDQIL6I5ANCNFSM4IUOHMVA>
.
--
Jacquelyn Shuman
Terrestrial Sciences Section
NCAR
|
Ok @slevisconsulting . Now I see that this is a PR to my jkshuman_repo. I think you will need to try to create a new PR to the FATES_repo. Not sure how this happened. Maybe @rgknox has insight... |
@jkshuman I will not delete this PR until I have created its replacement in slevis_repo (probably tomorrow) because I will copy&paste the description from here to the new one. |
Of course. No problem at all
On Mon, Sep 9, 2019 at 5:55 PM Samuel Levis ***@***.***> wrote:
@jkshuman <https://github.com/jkshuman> I will not delete this PR until I
have created its replacement in slevis_repo (probably tomorrow) because I
will copy&paste the description from here to the new one.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5?email_source=notifications&email_token=AFIUHBWTN5XVSORDMTEQN2DQI3O7NA5CNFSM4IUOHMVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6JMAVY#issuecomment-529711191>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFIUHBQT6NAZIPZANUG5QADQI3O7NANCNFSM4IUOHMVA>
.
--
Jacquelyn Shuman
Terrestrial Sciences Section
NCAR
|
…active_crown_fire Resolved conflicts in fire/SFMainMod.F90
@jkshuman working in my local branch I will be at NCAR the week of 9/23. Maybe we save cleaning this up for then? |
Or try Ryan. He is the git master...
On Wed, Sep 11, 2019 at 3:09 PM Samuel Levis ***@***.***> wrote:
@jkshuman <https://github.com/jkshuman> working in my local branch
active_crown_fire,
I merged the latest updates from your passive_crown_fire branch,
resolved conflicts, and then typed:
git commit
git push -u slevis_repo active_crown_fire
but I was not given the option to open a new PR.
The update showed up here even though git remote -v returns
slevis_repo https://github.com/slevisconsulting/fates.git (fetch)
slevis_repo https://github.com/slevisconsulting/fates.git (push)
I will be at NCAR the week of 9/23. Maybe we save cleaning this up for
then?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5?email_source=notifications&email_token=AFIUHBQM3ZHCBR73YVK2KT3QJFNBLA5CNFSM4IUOHMVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6P455A#issuecomment-530566900>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFIUHBWCZELPLDHVLNCEM5TQJFNBLANCNFSM4IUOHMVA>
.
--
Jacquelyn Shuman
Terrestrial Sciences Section
NCAR
|
…active_crown_fire Resolved Conflicts: main/EDTypesMod.F90
Also made two crown-related history varialbes active
…active_crown_fire Resolved conflicts in: fire/SFMainMod.F90 main/EDTypesMod.F90
This pft-dependent parameter is set in the fates params file. Use it instead of setting fraction_crown_burned = 1 for all passive crown fires.
…active_crown_fire Hoping that this returns to normal fire behavior. Problems reported previously: - @slevisconsulting saw fire in year 1 and not after - @jkshuman saw fire in years 1-5 and not after
The two new flags identifying when passive and active crown fires occur needed to be integers for the if statements to work correctly. To facilitate my debugging, I reverted some aesthetic code mods to look more like @jkshuman's read_lightning_pr561 branch (https://github.com/jkshuman/fates/tree/read_lightning_pr561) so as to minimize unnecessary diffs when typing "git diff read_lightning_pr561". These mods will likely make it back into this branch (active_crown_fire) with later updates.
I.e. currentCohort%n and currentCohort%c_area. Also 1) Moving active crown fire calculations inside the if statement that confirms ignition of a passive crown fire to increase code efficiency 2) Introducing diagnostic write statements to investigate crown fire behavior; remove in a later commit.
@slevisconsulting what is the status of moving this PR to the NGEET_repo? |
It's on the agenda for my next call with @rgknox. We have not set up such a call, because moving the PR has felt to me like a low priority issue. Since Jackie brought this up though, Ryan, pls email me a few convenient times in the next week or so when we may resolve this. Thanks! |
sounds good, I took a quick look at https://github.com/slevisconsulting/fates/tree/active_crown_fire and don't expect any major issues. |
@rgknox @slevisconsulting I am not advocating for pulling it into ngeet_repo/master, just putting it in the PR list on the ngeet_repo. Just want to be clear I am not trying to speed this along. this NGEET#573 still has a fair bit of development and has changes to the param file, so should be added with other PRs that have param changes. |
First testing of crown fire at CZ2 in a 1979-2015 simulation. I have found that passive crown fire may occur for Incidentally the crown fire simulation returns identical model results as the NO crown fire simulation. I have determined that this is because the same conditions that lead to passive crown fire in the crown fire simulation also lead to 100% scorch damage in the NO crown fire simulation. My intuition tells me that this is due to the characteristics of this ecosystem. I will look into this further. |
So I'm finding that scorch damage is more likely than passive crown fire (seems reasonable), and that the model...
So what we've done with the passive crown fire code is simply reclassify some 100% scorch cases to passive crown fire cases. When we scale passive crown fire effects to less than 100% this will reduce crown damage relative to current simulations. |
That's really interesting @slevisconsulting! Do we know yet how the current, no passive crown fire, simulations perform compared to observations? Since there's no fire at the CZ2 site, maybe we need to run over the ponderosa domain. We'll need to decide how to create the stand initialization files for that domain if we are going to compare to observed fire. One option is to give the entire domain the CZ2 stand structure. Or we could see if there are any FIA plots near grid cells with observed fire and run those grid cells only. |
@slevisconsulting you are correct that passive crown fire is the same as 100% scorch damage. In reality there are situations where the FI is enough to cause crown fire. |
Updating to sci.1.43.4_api.14.2 and incorporating Hui's fixes
Add dispersal fraction to parameter file and add seed in/out diagnostic history variables
Updated memory needed for phenoology restart
Following @jkshuman's introduction of the Bessie and Johnson (1995)
formulation for determining the presence of passive crown fire (NGEET#572), I now add the same paper's formulation for determining the presence of active crown fire.
Description:
All changes are in subroutine crown_damage:
Where @jkshuman introduced Eq. 8 from Bessie and Johnson (1995) I also introduced Eq. 12.
Where @jkshuman introduced Eq. 14a from Bessie and Johnson (1995) I also introduced Eq. 14b.
These equations determine whether passive/active crown fire will occur. As of 9/6/2019, I have not included the effects of active crown fire, which is a topic of discussion for now.
Discussion here:
NGEET#573
Collaborators:
@jkshuman @lmkueppers @pollybuotte @rgknox @rosiealice @xuchongang @ckoven
Expectation of Answer Changes:
Answers will change once we include the effect of active crown fires, not just their presence.
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: