Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active crown fire development #5

Closed

Conversation

slevis-lmwg
Copy link

@slevis-lmwg slevis-lmwg commented Sep 7, 2019

Following @jkshuman's introduction of the Bessie and Johnson (1995)
formulation for determining the presence of passive crown fire (NGEET#572), I now add the same paper's formulation for determining the presence of active crown fire.

Description:

All changes are in subroutine crown_damage:
Where @jkshuman introduced Eq. 8 from Bessie and Johnson (1995) I also introduced Eq. 12.
Where @jkshuman introduced Eq. 14a from Bessie and Johnson (1995) I also introduced Eq. 14b.

These equations determine whether passive/active crown fire will occur. As of 9/6/2019, I have not included the effects of active crown fire, which is a topic of discussion for now.

Discussion here:
NGEET#573

Collaborators:

@jkshuman @lmkueppers @pollybuotte @rgknox @rosiealice @xuchongang @ckoven

Expectation of Answer Changes:

Answers will change once we include the effect of active crown fires, not just their presence.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

Following @jkshuman's introduction of the Bessie and Johnson (1995)
formulation for determining the presence of passive crown fire
(NGEET#572),
I now add the same paper's formulation for determining the presence of
active crown fire.

The corresponding issue is NGEET#573
@slevis-lmwg
Copy link
Author

@rgknox somehow I opened this PR in @jkshuman's path of PRs. I don't know how...

@jkshuman
Copy link
Owner

jkshuman commented Sep 8, 2019 via email

@jkshuman
Copy link
Owner

jkshuman commented Sep 9, 2019

Ok @slevisconsulting . Now I see that this is a PR to my jkshuman_repo. I think you will need to try to create a new PR to the FATES_repo. Not sure how this happened. Maybe @rgknox has insight...

@slevis-lmwg
Copy link
Author

@jkshuman I will not delete this PR until I have created its replacement in slevis_repo (probably tomorrow) because I will copy&paste the description from here to the new one.

@jkshuman
Copy link
Owner

jkshuman commented Sep 10, 2019 via email

…active_crown_fire

Resolved conflicts in
 	fire/SFMainMod.F90
@slevis-lmwg
Copy link
Author

@jkshuman working in my local branch active_crown_fire,
I merged the latest updates from your passive_crown_fire branch,
resolved conflicts, and then typed:
git commit
git push -u slevis_repo active_crown_fire
but I was not given the option to open a new PR.
The update showed up here even though git remote -v returns
slevis_repo https://github.com/slevisconsulting/fates.git (fetch)
slevis_repo https://github.com/slevisconsulting/fates.git (push)

I will be at NCAR the week of 9/23. Maybe we save cleaning this up for then?

@jkshuman
Copy link
Owner

jkshuman commented Sep 11, 2019 via email

…active_crown_fire

Resolved Conflicts:
 	main/EDTypesMod.F90
Also made two crown-related history varialbes active
…active_crown_fire

Resolved conflicts in:
 	fire/SFMainMod.F90
 	main/EDTypesMod.F90
This pft-dependent parameter is set in the fates params file.
Use it instead of setting fraction_crown_burned = 1 for all passive
crown fires.
…active_crown_fire

Hoping that this returns to normal fire behavior. Problems reported
previously:
- @slevisconsulting saw fire in year 1 and not after
- @jkshuman saw fire in years 1-5 and not after
The two new flags identifying when passive and active crown fires
occur needed to be integers for the if statements to work correctly.

To facilitate my debugging, I reverted some aesthetic code mods to look
more like @jkshuman's read_lightning_pr561 branch
(https://github.com/jkshuman/fates/tree/read_lightning_pr561) so as to
minimize unnecessary diffs when typing "git diff read_lightning_pr561".
These mods will likely make it back into this branch (active_crown_fire)
with later updates.
I.e. currentCohort%n and currentCohort%c_area.
Also
1) Moving active crown fire calculations inside the if statement that
   confirms ignition of a passive crown fire to increase code efficiency
2) Introducing diagnostic write statements to investigate crown fire
   behavior; remove in a later commit.
@jkshuman
Copy link
Owner

jkshuman commented Oct 9, 2019

@slevisconsulting what is the status of moving this PR to the NGEET_repo?

@slevis-lmwg
Copy link
Author

@slevisconsulting what is the status of moving this PR to the NGEET_repo?

It's on the agenda for my next call with @rgknox. We have not set up such a call, because moving the PR has felt to me like a low priority issue. Since Jackie brought this up though, Ryan, pls email me a few convenient times in the next week or so when we may resolve this. Thanks!

@rgknox
Copy link

rgknox commented Oct 9, 2019

sounds good, I took a quick look at https://github.com/slevisconsulting/fates/tree/active_crown_fire and don't expect any major issues.

@jkshuman
Copy link
Owner

jkshuman commented Oct 9, 2019

@rgknox @slevisconsulting I am not advocating for pulling it into ngeet_repo/master, just putting it in the PR list on the ngeet_repo. Just want to be clear I am not trying to speed this along. this NGEET#573 still has a fair bit of development and has changes to the param file, so should be added with other PRs that have param changes.

@slevis-lmwg
Copy link
Author

First testing of crown fire at CZ2 in a 1979-2015 simulation.
Effects of active crown fire not included.
Currently, when passive crown fire occurs, fraction_crown_burned = 1.0

I have found that passive crown fire may occur for height_cbb ~< 1.3 m
and active crown fire may then occur for crown_fuel_bulkd >~ 0.98 kg leaf biomass/m3 canopy

Incidentally the crown fire simulation returns identical model results as the NO crown fire simulation. I have determined that this is because the same conditions that lead to passive crown fire in the crown fire simulation also lead to 100% scorch damage in the NO crown fire simulation. My intuition tells me that this is due to the characteristics of this ecosystem. I will look into this further.

@slevis-lmwg
Copy link
Author

I will look into this further.

So I'm finding that scorch damage is more likely than passive crown fire (seems reasonable), and that the model...

  • may simulate up to 100% scorch damage due to a tall Scorch Height (SH) at a time when passive crown fire cannot occur due to low Fire Intensity (FI), and it
  • will simulate 100% scorch damage (in the NO crown fire simulation) every time that a passive crown fire can occur in the crown fire simulation

So what we've done with the passive crown fire code is simply reclassify some 100% scorch cases to passive crown fire cases.

When we scale passive crown fire effects to less than 100% this will reduce crown damage relative to current simulations.

@pollybuotte
Copy link

That's really interesting @slevisconsulting! Do we know yet how the current, no passive crown fire, simulations perform compared to observations? Since there's no fire at the CZ2 site, maybe we need to run over the ponderosa domain. We'll need to decide how to create the stand initialization files for that domain if we are going to compare to observed fire. One option is to give the entire domain the CZ2 stand structure. Or we could see if there are any FIA plots near grid cells with observed fire and run those grid cells only.

@jkshuman
Copy link
Owner

@slevisconsulting you are correct that passive crown fire is the same as 100% scorch damage. In reality there are situations where the FI is enough to cause crown fire.
@slevisconsulting @pollybuotte I would also look at the assumptions in the parameters triggering crown fire. These are from a different system I think, and should be updated for CA. https://github.com/slevisconsulting/fates/blob/402dfd00d96b76448bec4313b4156525bc14da9f/fire/SFMainMod.F90#L936-L944

jkshuman pushed a commit that referenced this pull request Jan 28, 2022
Updating to sci.1.43.4_api.14.2 and incorporating Hui's fixes
adrifoster pushed a commit that referenced this pull request Oct 26, 2023
Add dispersal fraction to parameter file and add seed in/out diagnostic history variables
adrifoster pushed a commit that referenced this pull request Oct 26, 2023
Updated memory needed for phenoology restart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants