Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim newlines from files reading by secrets #343

Merged
merged 2 commits into from
Nov 8, 2024
Merged

fix: trim newlines from files reading by secrets #343

merged 2 commits into from
Nov 8, 2024

Conversation

jkroepke
Copy link
Owner

@jkroepke jkroepke commented Nov 2, 2024

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

@jkroepke jkroepke added the 🐞 bug Something isn't working label Nov 2, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.04%. Comparing base (e0da4f2) to head (7499ffa).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   81.80%   82.04%   +0.23%     
==========================================
  Files          51       51              
  Lines        3150     3152       +2     
==========================================
+ Hits         2577     2586       +9     
+ Misses        437      431       -6     
+ Partials      136      135       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkroepke jkroepke merged commit 53e599a into main Nov 8, 2024
7 checks passed
@jkroepke jkroepke deleted the secrets branch November 8, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oauth2.client.secret doesn't work when read from a file, but works when secret is passed plain-text
1 participant