Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a run wrapper for windows #42

Merged
merged 11 commits into from
Sep 12, 2020
Merged

Add a run wrapper for windows #42

merged 11 commits into from
Sep 12, 2020

Conversation

jkroepke
Copy link
Owner

@jkroepke jkroepke commented Sep 9, 2020

Add a shell wrapper for windows.

Try to find a bash in different way:

  • If HELM_SECRETS_WINDOWS_SHELL is defined (path to a shell or wsl provided by user), use it.
  • Lookup for a sh binary in path
  • Lookup defauft installation path of Git for Windows
  • Search git.exe (aside from default installations) and use the bash avaible inside
  • Use wsl, if installed.
  • Errored if all tries above failed.

@github-actions
Copy link
Contributor

sh-checker report

shellcheck output

In scripts/run.sh line 84:
if [ "$(basename "$1")" == "run.sh" ]; then
                        ^-- SC2039: In POSIX sh, == in place of = is undefined.

For more information:
  https://www.shellcheck.net/wiki/SC2039 -- In POSIX sh, == in place of = is ...

The files above have some shellcheck issues

shfmt output
No errors or shfmt is disabled

The files above have some formatting problems, you can use shfmt -w to fix them

To get the full details about this job

@jkroepke jkroepke marked this pull request as ready for review September 12, 2020 19:02
@jkroepke jkroepke merged commit 0484ea2 into master Sep 12, 2020
@jkroepke jkroepke deleted the windows-wsl branch September 12, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant