Skip to content

Commit

Permalink
Fix "OUTPUT_DECRYPTED_FILE_PATH: parameter not set" (#123)
Browse files Browse the repository at this point in the history
  • Loading branch information
jkroepke authored Jun 12, 2021
1 parent 7a27013 commit 72245db
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 6 deletions.
10 changes: 8 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

Allow override sops version on installation

## [3.8.0] - 2021-05-22
## [3.8.1] - 2021-06-12

### Fixed
- OUTPUT_DECRYPTED_FILE_PATH: parameter not set

## [3.8.0] - 2021-06-12

### Added
- New parameter `--output-decrypt-file-path` (`HELM_SECRETS_OUTPUT_DECRYPTED_FILE_PATH`) that outputs the path of decrypted files only.
Expand Down Expand Up @@ -143,7 +148,8 @@ Started a fork of https://github.com/zendesk/helm-secrets
- Support all helm sub commands and plugins


[Unreleased]: https://github.com/jkroepke/helm-secrets/compare/v3.8.0...HEAD
[Unreleased]: https://github.com/jkroepke/helm-secrets/compare/v3.8.1...HEAD
[3.8.1]: https://github.com/jkroepke/helm-secrets/compare/v3.8.1...v3.8.1
[3.8.0]: https://github.com/jkroepke/helm-secrets/compare/v3.7.0...v3.8.0
[3.7.0]: https://github.com/jkroepke/helm-secrets/compare/v3.6.1...v3.7.0
[3.6.1]: https://github.com/jkroepke/helm-secrets/compare/v3.6.0...v3.6.1
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ By default, helm plugin install does this for you.

Install a specific version (recommend)
```bash
helm plugin install https://github.com/jkroepke/helm-secrets --version v3.8.0
helm plugin install https://github.com/jkroepke/helm-secrets --version v3.8.1
```

Install latest unstable version from main branch
Expand All @@ -114,11 +114,11 @@ curl -LsSf https://github.com/jkroepke/helm-secrets/releases/latest/download/hel

Windows (inside cmd, needs to be verified)
```bash
curl -LsSf https://github.com/jkroepke/helm-secrets/releases/download/v3.8.0/helm-secrets.tar.gz | tar -C "%APPDATA%\helm\plugins" -xzf-
curl -LsSf https://github.com/jkroepke/helm-secrets/releases/download/v3.8.1/helm-secrets.tar.gz | tar -C "%APPDATA%\helm\plugins" -xzf-
```
MacOS / Linux
```bash
curl -LsSf https://github.com/jkroepke/helm-secrets/releases/download/v3.8.0/helm-secrets.tar.gz | tar -C "$(helm env HELM_PLUGINS)" -xzf-
curl -LsSf https://github.com/jkroepke/helm-secrets/releases/download/v3.8.1/helm-secrets.tar.gz | tar -C "$(helm env HELM_PLUGINS)" -xzf-
```

### Installation on Helm 2
Expand Down
15 changes: 14 additions & 1 deletion scripts/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,10 @@ TMPDIR="${HELM_SECRETS_DEC_TMP_DIR:-"$(mktemp -d)"}"
export TMPDIR
mkdir -p "${TMPDIR}"

OUTPUT_DECRYPTED_FILE_PATH="${HELM_SECRETS_OUTPUT_DECRYPTED_FILE_PATH:-false}"

# Output debug infos
QUIET="${HELM_SECRETS_QUIET:-false}"
QUIET="${HELM_SECRETS_QUIET:-"${OUTPUT_DECRYPTED_FILE_PATH}"}"

# Define the secret driver engine
SECRET_DRIVER="${HELM_SECRETS_DRIVER:-sops}"
Expand Down Expand Up @@ -133,10 +135,21 @@ while true; do
help_usage
break
;;
--version | -v | version)
# shellcheck source=scripts/commands/version.sh
. "${SCRIPT_DIR}/commands/version.sh"
version
break
;;
--driver | -d)
load_secret_driver "$2"
shift
;;
--output-decrypt-file-path)
# shellcheck disable=SC2034
OUTPUT_DECRYPTED_FILE_PATH=true
QUIET=true
;;
--quiet | -q)
# shellcheck disable=SC2034
QUIET=true
Expand Down

0 comments on commit 72245db

Please sign in to comment.