DisableReflection

jkotas · Oct 28, 2023 · baea1e5 · baea1e5
1 parent ba8f71c
commit baea1e5
Show file tree

Hide file tree

Showing 13 changed files with 95 additions and 603 deletions.
diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
@@ -108,7 +108,6 @@ The .NET Foundation licenses this file to you under the MIT license.
     <AutoInitializedAssemblies Include="System.Private.StackTraceMetadata" Condition="$(StackTraceSupport) != 'false'" />
     <AutoInitializedAssemblies Include="System.Private.TypeLoader" />
     <AutoInitializedAssemblies Include="System.Private.Reflection.Execution" Condition="$(IlcDisableReflection) != 'true'" />
-    <AutoInitializedAssemblies Include="System.Private.DisabledReflection" Condition="$(IlcDisableReflection) == 'true'" />
   </ItemGroup>
 
   <ItemDefinitionGroup>

diff --git a/src/coreclr/nativeaot/System.Private.CoreLib/src/System/MetadataOnlyType.cs b/src/coreclr/nativeaot/System.Private.CoreLib/src/System/MetadataOnlyType.cs
@@ -72,6 +72,9 @@ public override Array GetEnumValuesAsUnderlyingType()
             throw new ArgumentException(SR.Arg_MustBeEnum, "enumType");
         }
 
+        public override int GetHashCode()
+            => RuntimeHelpers.GetHashCode(this);
+
         public override RuntimeTypeHandle TypeHandle
             => GetRuntimeTypeInfo().TypeHandle;
 
@@ -183,6 +186,11 @@ public override Type GetFunctionPointerReturnType()
         // Implementation shared with MetadataType
         //
 
+        public override string ToString()
+            => GetRuntimeTypeInfo().ToString();
+
+        public override bool Equals(object? obj) => ReferenceEquals(obj, this);
+
         object ICloneable.Clone() => this;
 
         public override bool IsSecurityCritical => true;
@@ -289,6 +297,8 @@ public override IEnumerable<CustomAttributeData> CustomAttributes
         public override IList<CustomAttributeData> GetCustomAttributesData()
             => GetRuntimeTypeInfo().GetCustomAttributesData();
 
+        public override string Name => GetRuntimeTypeInfo().Name;
+
         public override string? Namespace => GetRuntimeTypeInfo().Namespace;
 
         public override string? AssemblyQualifiedName => GetRuntimeTypeInfo().AssemblyQualifiedName;
@@ -301,8 +311,6 @@ public override IList<CustomAttributeData> GetCustomAttributesData()
 
         public override Guid GUID => GetRuntimeTypeInfo().GUID;
 
-        public override string Name => GetRuntimeTypeInfo().Name;
-
         public override bool HasSameMetadataDefinitionAs(MemberInfo other) => GetRuntimeTypeInfo().HasSameMetadataDefinitionAs(other);
 
         public override Type MakePointerType()

diff --git a/src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeType.cs b/src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeType.cs
@@ -31,8 +31,17 @@ internal RuntimeType(MethodTable* pUnderlyingEEType)
 
         internal RuntimeTypeInfo GetRuntimeTypeInfo() => _runtimeTypeInfo ?? CreateRuntimeTypeInfo();
 
+        private static bool IsReflectionDisabled => false;
+
+        private static bool DoNotThrowForNames => AppContext.TryGetSwitch("Switch.System.Reflection.Disabled.DoNotThrowForNames", out bool doNotThrow) && doNotThrow;
+        private static bool DoNotThrowForAssembly => AppContext.TryGetSwitch("Switch.System.Reflection.Disabled.DoNotThrowForAssembly", out bool doNotThrow) && doNotThrow;
+        private static bool DoNotThrowForAttributes => AppContext.TryGetSwitch("Switch.System.Reflection.Disabled.DoNotThrowForAttributes", out bool doNotThrow) && doNotThrow;
+
         private RuntimeTypeInfo CreateRuntimeTypeInfo()
         {
+            if (IsReflectionDisabled)
+                throw new NotSupportedException(SR.Reflection_Disabled);
+
             EETypePtr eeType = ToEETypePtr();
 
             RuntimeTypeHandle runtimeTypeHandle = new RuntimeTypeHandle(eeType);
@@ -186,6 +195,9 @@ public override Array GetEnumValuesAsUnderlyingType()
             return Enum.GetValuesAsUnderlyingType(this);
         }
 
+        public override int GetHashCode()
+            => ((nuint)_pUnderlyingEEType).GetHashCode();
+
         public override RuntimeTypeHandle TypeHandle
             => new RuntimeTypeHandle(_pUnderlyingEEType);
 
@@ -267,7 +279,7 @@ public override Type[] GetInterfaces()
         }
 
         public override bool IsTypeDefinition
-            => (_pUnderlyingEEType->IsCanonical &&  !_pUnderlyingEEType->IsGeneric) || _pUnderlyingEEType->IsGenericTypeDefinition;
+            => (_pUnderlyingEEType->IsCanonical && !_pUnderlyingEEType->IsGeneric) || _pUnderlyingEEType->IsGenericTypeDefinition;
 
         public override bool IsGenericType
             => _pUnderlyingEEType->IsGeneric || _pUnderlyingEEType->IsGenericTypeDefinition;
@@ -375,6 +387,16 @@ public override Type GetFunctionPointerReturnType()
         // Implementation shared with MetadataType
         //
 
+        public override string ToString()
+        {
+            if (IsReflectionDisabled)
+                return "0x" + ((nuint)_pUnderlyingEEType).ToString("x");
+
+            return GetRuntimeTypeInfo().ToString();
+        }
+
+        public override bool Equals(object? obj) => ReferenceEquals(obj, this);
+
         object ICloneable.Clone() => this;
 
         public override bool IsSecurityCritical => true;
@@ -470,31 +492,81 @@ public override bool IsDefined(Type attributeType, bool inherit)
             => GetRuntimeTypeInfo().IsDefined(attributeType, inherit);
 
         public override object[] GetCustomAttributes(bool inherit)
-            => GetRuntimeTypeInfo().GetCustomAttributes(inherit);
+        {
+            if (IsReflectionDisabled && DoNotThrowForAttributes)
+                return Array.Empty<object>();
+
+            return GetRuntimeTypeInfo().GetCustomAttributes(inherit);
+        }
 
         public override object[] GetCustomAttributes(Type attributeType, bool inherit)
-            => GetRuntimeTypeInfo().GetCustomAttributes(attributeType, inherit);
+        {
+            if (IsReflectionDisabled && DoNotThrowForAttributes)
+                return Array.Empty<object>();
+
+            return GetRuntimeTypeInfo().GetCustomAttributes(attributeType, inherit);
+        }
 
         public override IEnumerable<CustomAttributeData> CustomAttributes
-            => GetRuntimeTypeInfo().CustomAttributes;
+        {
+            get
+            {
+                if (IsReflectionDisabled && DoNotThrowForAttributes)
+                    return Array.Empty<CustomAttributeData>();
+
+                return GetRuntimeTypeInfo().CustomAttributes;
+            }
+        }
 
         public override IList<CustomAttributeData> GetCustomAttributesData()
-            => GetRuntimeTypeInfo().GetCustomAttributesData();
+        {
+            if (IsReflectionDisabled && DoNotThrowForAttributes)
+                return Array.Empty<CustomAttributeData>();
 
-        public override string? Namespace => GetRuntimeTypeInfo().Namespace;
+            return GetRuntimeTypeInfo().GetCustomAttributesData();
+        }
+
+        public override string Name
+        {
+            get
+            {
+                if (IsReflectionDisabled && DoNotThrowForNames)
+                    return ToString();
+
+                return GetRuntimeTypeInfo().Name;
+            }
+        }
+
+        public override string? Namespace
+        {
+            get
+            {
+                if (IsReflectionDisabled && DoNotThrowForNames)
+                    return null;
+
+                return GetRuntimeTypeInfo().Namespace;
+            }
+        }
 
         public override string? AssemblyQualifiedName => GetRuntimeTypeInfo().AssemblyQualifiedName;
 
         public override string? FullName => GetRuntimeTypeInfo().FullName;
 
-        public override Assembly Assembly => GetRuntimeTypeInfo().Assembly;
+        public override Assembly Assembly
+        {
+            get
+            {
+                if (IsReflectionDisabled && DoNotThrowForAssembly)
+                    return null!; // TODO!!!!!!!!!!
+
+                return GetRuntimeTypeInfo().Assembly;
+            }
+        }
 
         public override Module Module => GetRuntimeTypeInfo().Module;
 
         public override Guid GUID => GetRuntimeTypeInfo().GUID;
 
-        public override string Name => GetRuntimeTypeInfo().Name;
-
         public override bool HasSameMetadataDefinitionAs(MemberInfo other) => GetRuntimeTypeInfo().HasSameMetadataDefinitionAs(other);
 
         public override Type MakePointerType()

diff --git a/...ivate.DisabledReflection/src/Internal/Reflection/ReflectionCoreCallbacksImplementation.cs b/...ivate.DisabledReflection/src/Internal/Reflection/ReflectionCoreCallbacksImplementation.cs
diff --git a/...ledReflection/src/Internal/Reflection/ReflectionExecutionDomainCallbacksImplementation.cs b/...ledReflection/src/Internal/Reflection/ReflectionExecutionDomainCallbacksImplementation.cs
diff --git a/...ativeaot/System.Private.DisabledReflection/src/Internal/Reflection/RuntimeAssemblyInfo.cs b/...ativeaot/System.Private.DisabledReflection/src/Internal/Reflection/RuntimeAssemblyInfo.cs