Implemented a cache post-delete hook. #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
reviewed
Oct 27, 2016
| @@ -9,11 +9,28 @@ self.addEventListener('activate', function(event) { | |||
| return (cacheName.indexOf('$$$inactive$$$') === -1 && cacheName.indexOf(CACHE_PREFIX) === 0 && cacheName !== CACHE_VERSION); | |||
| }).map(function(cacheName) { | |||
| logDebug('Deleting out of date cache:', cacheName); | |||
| return caches.delete(cacheName); | |||
| return caches.delete(cacheName).then(function() { | |||
There was a problem hiding this comment.
@bourquep why not check for existence of function here instead of catching non existence of function in _postDeleteCacheHook? Seems like that would be simpler? Something like
if (brocswPostDeleteCacheHook) {
return brocswPostDeleteCacheHook(cacheName);
} else {
return Promise.resolve();
}There was a problem hiding this comment.
Indeed. I'll update and test. JS is not my main programming language and I was not aware that it could be done that way.
|
@jkleinsc done. |
|
Had to rebase and force-push my branch. PR is clean now. |
|
@bourquep looks good to me. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case is:
My service worker creates an IndexedDB database to store some offline data. The database name corresponds to the cache name, so that it can leverage the
CACHE_VERSIONversioning mechanism and start fresh when the service worker code changes.I needed a way to delete stale databases just like old caches are deleted in the
activateevent handled bydelete-old-caches.js. I figured that a hook would be appropriate, where the service worker code simply needs to define a specific function name to enable the hook.