Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use absolute path instead of relative path #31

Merged

Conversation

rmehner
Copy link
Contributor

@rmehner rmehner commented Aug 5, 2016

We're using this addon for our ember service worker and it works quite nice so far. Thanks! :)

Little thing we noticed: If you go straight to a subroute (let's say /authenticate/123456) you'll see this in your console:

coach

With this PR the URL is just the root URL and absolute and the service worker installs as needed. Does this make sense?

@rmehner
Copy link
Contributor Author

rmehner commented Aug 5, 2016

Alternatively I thought about using {{rootURL}}, but that only works for Ember 2.7+ if I'm not mistaken.

@rmehner
Copy link
Contributor Author

rmehner commented Aug 16, 2016

@jkleinsc is there anything I can do to help you with getting this merged & released? :)

@jkleinsc
Copy link
Owner

@rmehner sorry I was away. looks good to me. I'll merge it in.

@jkleinsc jkleinsc merged commit 3632e6d into jkleinsc:master Aug 17, 2016
@rmehner rmehner deleted the fixes/use-root-url-for-registration branch August 17, 2016 16:37
@rmehner
Copy link
Contributor Author

rmehner commented Sep 6, 2016

@jkleinsc Thanks for merging :) Is there any chance to see this in a release soon?

@jkleinsc
Copy link
Owner

@rmehner I am going to push a release today.

@jkleinsc
Copy link
Owner

@rmehner new release now available: https://www.npmjs.com/package/broccoli-serviceworker

@rmehner
Copy link
Contributor Author

rmehner commented Sep 12, 2016

Thank you :)

@miguelcobain
Copy link
Contributor

@rmehner I see the problem now. I'm using locationType: 'hash', so I don't have this kind of problem.
Yes, we should fix this using that approach, because this will break any application not located at the root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants