Options: only set selected attribute when its true #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The selected attribute for an option element was always being set to either true or false. This breaks the selected attribute rendering (at least in Chrome). Only one option should ever have the selected attribute.
|
@iku000888 I had to re-do this since I had deleted my fork. I've included the README update in here. Since there's no existing tests I won't be adding any for this since I haven't written clojure in almost 2 years :) |
|
Thank you so much for taking the extra effort! (Prob. not a bad idea to come back to Clojure land, just saying... Hehe) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-do of #36