Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a quick way to format 'until' in toText #313

Merged
merged 1 commit into from
Jan 20, 2019
Merged

Add a quick way to format 'until' in toText #313

merged 1 commit into from
Jan 20, 2019

Conversation

LosD
Copy link

@LosD LosD commented Jan 7, 2019

It's not the most beautiful of ways, essentially adding an optional argument to RRule.toText, but with NLP being split out, it seemed like an okay stopgap for now. I'd have preferred adding a method to the Language interface, but I couldn't without either breaking existing Language implementations (compile-time only, though), or making a new sub interface. This seemed a bit cleaner.

Fixes #312


Thanks for contributing to rrule!

To submit a pull request, please verify that you have done the following:

  • Merged in or rebased on the latest master commit
  • Linked to an existing bug or issue describing the bug or feature you're
    addressing
  • Written one or more tests showing that your change works as advertised
  • Run yarn build to rebuild the dist/ files

@codecov-io
Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #313 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
+ Coverage   89.87%   89.88%   +0.01%     
==========================================
  Files          28       28              
  Lines        1945     1947       +2     
  Branches      581      581              
==========================================
+ Hits         1748     1750       +2     
  Misses        197      197
Impacted Files Coverage Δ
src/rrule.ts 98.98% <100%> (ø) ⬆️
src/nlp/index.ts 100% <100%> (ø) ⬆️
src/nlp/totext.ts 95.85% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 082d6eb...3ca920e. Read the comment docs.

@davidgoli
Copy link
Collaborator

Looks good to me, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants