Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many tests fail... #1

Closed
conrad-vanl opened this issue Nov 18, 2012 · 4 comments
Closed

Many tests fail... #1

conrad-vanl opened this issue Nov 18, 2012 · 4 comments
Labels

Comments

@conrad-vanl
Copy link

Scratching my head for several hours now. It looks like a majority of the test cases fail for me, in fact, the only cases that pass are 1-8 and then a few throughout (very few) and 222-224. It almost looks like to me that RRule is setting the starting day at as a day earlier, as the expected results are behind 1:

testYearly:
Expected:
"Tue Sep 02 1997 09:00:00 GMT-0500 (Central Daylight Time)"
Result:
"Tue Sep 01 1998 09:00:00 GMT-0500 (Central Daylight Time)"

testYearlyByMonthDay:

Expected:
"Wed Sep 03 1997 09:00:00 GMT-0500 (Central Daylight Time)"
Result:
"Tue Sep 02 1997 09:00:00 GMT-0500 (Central Daylight Time)"
Diff:
"Wed "Tue Sep 03 02 1997 09:00:00 GMT-0500 (Central Daylight Time)"
Source:
at assertDatesEqual (file:///D:/Sites/rrule/test/utils.js:52:9)
at Object. (file:///D:/Sites/rrule/test/utils.js:85:9)

etc...

Are you getting the same?

@jkbrzt
Copy link
Owner

jkbrzt commented Nov 18, 2012

It looks like a DST-related issue. What timezone are you in?

@conrad-vanl
Copy link
Author

Central Daylight Time. We are currently not on daylight savings time.
That's what I originally thought. But couldn't figure out why that would make it adjust by 24 hours instead of just 1 hour.

@evan-waters
Copy link
Contributor

I'm having this issue as well. Currently on CST.

@jkbrzt jkbrzt closed this as completed in 6900b84 Jan 23, 2013
@jkbrzt
Copy link
Owner

jkbrzt commented Jan 24, 2013

Released v1.0.0 that includes @evro's fix. it's available via npm.

arolson101 pushed a commit that referenced this issue Feb 4, 2018
arolson101 pushed a commit that referenced this issue Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants